content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java - Issue 2908823002: Fix the handling of the text prosessing items in the popup menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

Issue 2908823002: Fix the handling of the text prosessing items in the popup menu (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java b/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

index 83614acc1fd2d5336b1748b2234b386c605dfa98..7484e3da8e60211ab1881ded5c094aeaba1688f2 100644

--- a/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

+++ b/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

@@ -558,7 +558,7 @@ public class SelectionPopupController extends ActionModeCallbackHelper {

int id = item.getItemId();

int groupId = item.getGroupId();

- if (id == mAssistMenuItemId) {

+ if (BuildInfo.isAtLeastO() && id == mAssistMenuItemId) {

doAssistAction();

mode.finish();

} else if (id == R.id.select_action_menu_select_all) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »