Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Issue 2908593004: Reland of Temporarily remove unit tests which use real git and real filesystem. (Closed)

Created:
3 years, 7 months ago by qyearsley
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, dmazzoni
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Temporarily remove unit tests which use real git and real filesystem. (patchset #1 id:1 of https://codereview.chromium.org/2891443003/ ) Reason for revert: These tests are failing again :-/ Possibly something changed with git on the bots again? Disabling tests for now to avoid making all of the unrelated try jobs red... Original issue's description: > Revert of Temporarily remove unit tests which use real git and real filesystem. (patchset #1 id:1 of https://codereview.chromium.org/2892463002/ ) > > Reason for revert: > Should be OK to run these tests again (https://bugs.chromium.org/p/chromium/issues/detail?id=722975#c10) > > Original issue's description: > > Temporarily remove unit tests which use real git and real filesystem. > > > > BUG=722975 > > TBR=dpranke > > NOTRY=true > > > > Review-Url: https://codereview.chromium.org/2892463002 > > Cr-Commit-Position: refs/heads/master@{#472223} > > Committed: https://chromium.googlesource.com/chromium/src/+/02e0ec9c924364de9287e06255649674a75493d1 > > TBR=dmazzoni@chromium.org,dpranke@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=722975 > > Review-Url: https://codereview.chromium.org/2891443003 > Cr-Commit-Position: refs/heads/master@{#472256} > Committed: https://chromium.googlesource.com/chromium/src/+/3948d50a08e75cd127eea4ae47267adeb1d945bf TBR=dmazzoni@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=722975 Review-Url: https://codereview.chromium.org/2908593004 Cr-Commit-Position: refs/heads/master@{#474866} Committed: https://chromium.googlesource.com/chromium/src/+/35981e40fcdc003eec5cd83736b8b455082c4439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -179 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_unittest.py View 1 chunk +0 lines, -179 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
qyearsley
Created Reland of Temporarily remove unit tests which use real git and real filesystem.
3 years, 7 months ago (2017-05-25 23:41:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908593004/1
3 years, 7 months ago (2017-05-25 23:43:04 UTC) #3
Dirk Pranke
lgtm. I don't know of anything changing on the bots, particularly.
3 years, 7 months ago (2017-05-26 00:03:33 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 01:24:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/35981e40fcdc003eec5cd83736b8...

Powered by Google App Engine
This is Rietveld 408576698