Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2892463002: Temporarily remove unit tests which use real git and real filesystem. (Closed)

Created:
3 years, 7 months ago by qyearsley
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, dmazzoni
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily remove unit tests which use real git and real filesystem. BUG=722975 TBR=dpranke NOTRY=true Review-Url: https://codereview.chromium.org/2892463002 Cr-Commit-Position: refs/heads/master@{#472223} Committed: https://chromium.googlesource.com/chromium/src/+/02e0ec9c924364de9287e06255649674a75493d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -179 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_unittest.py View 1 chunk +0 lines, -179 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
qyearsley
3 years, 7 months ago (2017-05-16 21:24:00 UTC) #2
dmazzoni
lgtm
3 years, 7 months ago (2017-05-16 21:27:11 UTC) #5
dmazzoni
TBR:dpranke Adding NOTRY=true because this is affecting the tree and trybots
3 years, 7 months ago (2017-05-16 21:31:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892463002/1
3 years, 7 months ago (2017-05-16 21:34:30 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/02e0ec9c924364de9287e06255649674a75493d1
3 years, 7 months ago (2017-05-16 21:44:05 UTC) #14
Dirk Pranke
lgtm
3 years, 7 months ago (2017-05-16 22:23:38 UTC) #15
qyearsley
3 years, 7 months ago (2017-05-16 23:56:27 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2891443003/ by qyearsley@chromium.org.

The reason for reverting is: Should be OK to run these tests again
(https://bugs.chromium.org/p/chromium/issues/detail?id=722975#c10).

Powered by Google App Engine
This is Rietveld 408576698