Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2891443003: Revert of Temporarily remove unit tests which use real git and real filesystem. (Closed)

Created:
3 years, 7 months ago by qyearsley
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, dmazzoni
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Temporarily remove unit tests which use real git and real filesystem. (patchset #1 id:1 of https://codereview.chromium.org/2892463002/ ) Reason for revert: Should be OK to run these tests again (https://bugs.chromium.org/p/chromium/issues/detail?id=722975#c10) Original issue's description: > Temporarily remove unit tests which use real git and real filesystem. > > BUG=722975 > TBR=dpranke > NOTRY=true > > Review-Url: https://codereview.chromium.org/2892463002 > Cr-Commit-Position: refs/heads/master@{#472223} > Committed: https://chromium.googlesource.com/chromium/src/+/02e0ec9c924364de9287e06255649674a75493d1 TBR=dmazzoni@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=722975 Review-Url: https://codereview.chromium.org/2891443003 Cr-Commit-Position: refs/heads/master@{#472256} Committed: https://chromium.googlesource.com/chromium/src/+/3948d50a08e75cd127eea4ae47267adeb1d945bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -0 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_unittest.py View 1 chunk +179 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
qyearsley
Created Revert of Temporarily remove unit tests which use real git and real filesystem.
3 years, 7 months ago (2017-05-16 23:56:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891443003/1
3 years, 7 months ago (2017-05-16 23:57:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3948d50a08e75cd127eea4ae47267adeb1d945bf
3 years, 7 months ago (2017-05-16 23:58:23 UTC) #6
qyearsley
3 years, 7 months ago (2017-05-25 23:41:44 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2908593004/ by qyearsley@chromium.org.

The reason for reverting is: These tests are failing again :-/

Possibly something changed with git on the bots again?

Disabling tests for now to avoid making all of the unrelated try jobs red....

Powered by Google App Engine
This is Rietveld 408576698