Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2907643004: [DMC #22] Move DocumentMarker::MatchStatus enum to TextMatchMarker (Closed)

Created:
3 years, 7 months ago by rlanday
Modified:
3 years, 6 months ago
Reviewers:
tkent, yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move DocumentMarker::MatchStatus enum to TextMatchMarker This enum is only used by TextMatch markers and should be defined in TextMatchMarker. BUG=707867 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2907643004 Cr-Commit-Position: refs/heads/master@{#476186} Committed: https://chromium.googlesource.com/chromium/src/+/ee4c66154e323f1cefbebae38cf4cafa2c19e080

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -146 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 1 12 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SplitTextNodeCommandTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarker.h View 1 2 5 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp View 1 2 5 chunks +7 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp View 1 2 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditorTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerTest.cpp View 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h View 1 2 1 chunk +25 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImplTest.cpp View 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 1 2 4 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 2 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/TextFinder.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (15 generated)
rlanday
Note: I believe this completes the changes to TextMatchMarker I want to make at this ...
3 years, 7 months ago (2017-05-25 22:50:04 UTC) #2
yosin_UTC9
lgtm +tkent@, for core/testing and web/
3 years, 7 months ago (2017-05-26 04:48:44 UTC) #4
tkent
lgtm
3 years, 7 months ago (2017-05-26 04:53:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907643004/40001
3 years, 6 months ago (2017-06-01 01:55:14 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 04:16:41 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ee4c66154e323f1cefbebae38cf4...

Powered by Google App Engine
This is Rietveld 408576698