Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

Issue 2907643004: [DMC #22] Move DocumentMarker::MatchStatus enum to TextMatchMarker (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
index 2a1dd7d1fbfcf2cbb079740ce22c2f5e14024b02..f0c8d38ab0761ec68219ab4e431cd4e4611bf80c 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
@@ -36,9 +36,7 @@ class DocumentMarkerDetails;
// A range of a node within a document that is "marked", such as the range of a
// misspelled word. It optionally includes a description that could be displayed
-// in the user interface. It also optionally includes a flag specifying whether
-// the match is active, which is ignored for all types other than type
-// TextMatch.
+// in the user interface.
class CORE_EXPORT DocumentMarker : public GarbageCollected<DocumentMarker> {
public:
enum MarkerTypeIndex {
@@ -130,8 +128,6 @@ class CORE_EXPORT DocumentMarker : public GarbageCollected<DocumentMarker> {
MisspellingMarkers() : MarkerTypes(kSpelling | kGrammar) {}
};
- enum class MatchStatus { kInactive, kActive };
-
DocumentMarker(MarkerType,
unsigned start_offset,
unsigned end_offset,
@@ -147,13 +143,11 @@ class CORE_EXPORT DocumentMarker : public GarbageCollected<DocumentMarker> {
unsigned EndOffset() const { return end_offset_; }
const String& Description() const;
- bool IsActiveMatch() const;
Color UnderlineColor() const;
bool Thick() const;
Color BackgroundColor() const;
DocumentMarkerDetails* Details() const;
- void SetIsActiveMatch(bool);
void ClearDetails() { details_.Clear(); }
struct MarkerOffsets {
@@ -174,10 +168,10 @@ class CORE_EXPORT DocumentMarker : public GarbageCollected<DocumentMarker> {
DECLARE_TRACE();
protected:
- DocumentMarker(unsigned start_offset, unsigned end_offset, MatchStatus);
+ DocumentMarker(MarkerType, unsigned start_offset, unsigned end_offset);
private:
- MarkerType type_;
+ const MarkerType type_;
unsigned start_offset_;
unsigned end_offset_;
Member<DocumentMarkerDetails> details_;
@@ -197,7 +191,6 @@ class DocumentMarkerDetails
DocumentMarkerDetails() {}
virtual ~DocumentMarkerDetails();
virtual bool IsDescription() const { return false; }
- virtual bool IsTextMatch() const { return false; }
virtual bool IsComposition() const { return false; }
DEFINE_INLINE_VIRTUAL_TRACE() {}

Powered by Google App Engine
This is Rietveld 408576698