Add new mark-non-secure-as options to chrome://flags

Add new mark-non-secure-as options to chrome://flags

Non-secure HTTP cannot meet users’ security and privacy expectations
when browsing the web. This change introduces new flag states which will
control marking HTTP pages as non-secure in Incognito mode and after
editing HTML forms. Subsequent CLs will detect the new flag states and
adjust the Security Chip UI warnings accordingly.

BUG=721896
Review-Url: https://codereview.chromium.org/2907153006
Cr-Commit-Position: refs/heads/master@{#475803}
Committed: https://chromium.googlesource.com/chromium/src/+/528541268e541b20e632380fd22aba8aeac53521

[elawrence, 2017-05-30 20:03:54]

Patchset #1 (id:1) has been deleted

[elawrence, 2017-05-30 20:18:14]

elawrence@chromium.org changed reviewers:
+ estark@chromium.org

[elawrence, 2017-05-30 20:18:15]

PTAL?

https://codereview.chromium.org/2907153006/diff/20001/components/security_sta...
File components/security_state/core/security_state.cc (right):

https://codereview.chromium.org/2907153006/diff/20001/components/security_sta...
components/security_state/core/security_state.cc:20: // These values are written
to logs. New enum values can be added, but existing
Updated comment and made numbering explicit per
https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histo...

[estark, 2017-05-30 22:46:42]

lgtm

https://codereview.chromium.org/2907153006/diff/20001/chrome/browser/flag_des...
File chrome/browser/flag_descriptions.cc (right):

https://codereview.chromium.org/2907153006/diff/20001/chrome/browser/flag_des...
chrome/browser/flag_descriptions.cc:176: "Warn on HTTP while editing forms";
nit: description makes it sound like the warning will go away when you stop
editing. Maybe "Warn on HTTP pages for which the user has edited form fields" or
something like that?

https://codereview.chromium.org/2907153006/diff/20001/components/security_sta...
File components/security_state/core/security_state.cc (right):

https://codereview.chromium.org/2907153006/diff/20001/components/security_sta...
components/security_state/core/security_state.cc:20: // These values are written
to logs. New enum values can be added, but existing
On 2017/05/30 20:18:14, elawrence wrote:
> Updated comment and made numbering explicit per
>
https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histo...

Thanks!

[elawrence, 2017-05-30 23:47:07]

Thanks for the quick review! Proposed tweak:

https://codereview.chromium.org/2907153006/diff/20001/chrome/browser/flag_des...
File chrome/browser/flag_descriptions.cc (right):

https://codereview.chromium.org/2907153006/diff/20001/chrome/browser/flag_des...
chrome/browser/flag_descriptions.cc:176: "Warn on HTTP while editing forms";
On 2017/05/30 22:46:42, estark wrote:
> nit: description makes it sound like the warning will go away when you stop
> editing. Maybe "Warn on HTTP pages for which the user has edited form fields"
or
> something like that?

Would "Warn on HTTP after editing forms" resolve the concern?

[estark, 2017-05-31 00:08:44]

On 2017/05/30 23:47:07, elawrence wrote:
> Thanks for the quick review! Proposed tweak:
> 
>
https://codereview.chromium.org/2907153006/diff/20001/chrome/browser/flag_des...
> File chrome/browser/flag_descriptions.cc (right):
> 
>
https://codereview.chromium.org/2907153006/diff/20001/chrome/browser/flag_des...
> chrome/browser/flag_descriptions.cc:176: "Warn on HTTP while editing forms";
> On 2017/05/30 22:46:42, estark wrote:
> > nit: description makes it sound like the warning will go away when you stop
> > editing. Maybe "Warn on HTTP pages for which the user has edited form
fields"
> or
> > something like that?
> 
> Would "Warn on HTTP after editing forms" resolve the concern?

Works for me!

[elawrence, 2017-05-31 00:58:13]

The CQ bit was checked by elawrence@chromium.org

[elawrence, 2017-05-31 00:58:13]

The patchset sent to the CQ was uploaded after l-g-t-m from estark@chromium.org
Link to the patchset: https://codereview.chromium.org/2907153006/#ps40001
(title: "Change 'while' to 'after'")

[commit-bot: I haz the power, 2017-05-31 00:59:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 02:04:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 02:04:42]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[elawrence, 2017-05-31 03:54:53]

The CQ bit was checked by elawrence@chromium.org

[commit-bot: I haz the power, 2017-05-31 03:55:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 04:36:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496202893408430,
"parent_rev": "a1791bf82e9140d86077ce778c9cab24e9eae540", "commit_rev":
"528541268e541b20e632380fd22aba8aeac53521"}

[commit-bot: I haz the power, 2017-05-31 04:36:15]

Description was changed from

==========
Add new mark-non-secure-as options to chrome://flags

Non-secure HTTP cannot meet users’ security and privacy expectations
when browsing the web. This change introduces new flag states which will
control marking HTTP pages as non-secure in Incognito mode and after
editing HTML forms. Subsequent CLs will detect the new flag states and
adjust the Security Chip UI warnings accordingly.

BUG=721896
==========

to

==========
Add new mark-non-secure-as options to chrome://flags

Non-secure HTTP cannot meet users’ security and privacy expectations
when browsing the web. This change introduces new flag states which will
control marking HTTP pages as non-secure in Incognito mode and after
editing HTML forms. Subsequent CLs will detect the new flag states and
adjust the Security Chip UI warnings accordingly.

BUG=721896

Review-Url: https://codereview.chromium.org/2907153006
Cr-Commit-Position: refs/heads/master@{#475803}
Committed:
https://chromium.googlesource.com/chromium/src/+/528541268e541b20e632380fd22a...
==========

[commit-bot: I haz the power, 2017-05-31 04:36:19]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/528541268e541b20e632380fd22a...