Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: components/security_state/core/security_state.cc

Issue 2907153006: Add new mark-non-secure-as options to chrome://flags (Closed)
Patch Set: Change 'while' to 'after' Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/flag_descriptions.cc ('k') | components/security_state/core/switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/security_state/core/security_state.cc
diff --git a/components/security_state/core/security_state.cc b/components/security_state/core/security_state.cc
index aed4e42d2bfd73eea7accb8bd632d780326bb5f8..a958bf3df8a3d3de16ad86597886f69893e8c7dc 100644
--- a/components/security_state/core/security_state.cc
+++ b/components/security_state/core/security_state.cc
@@ -17,12 +17,15 @@ namespace security_state {
namespace {
-// Do not change or reorder this enum, and add new values at the end. It is used
-// in the MarkHttpAs histogram.
+// These values are written to logs. New enum values can be added, but existing
+// enums must never be renumbered or deleted and reused.
enum MarkHttpStatus {
- NEUTRAL /* deprecated */,
- NON_SECURE,
- HTTP_SHOW_WARNING_ON_SENSITIVE_FIELDS,
+ NEUTRAL = 0, // Deprecated
+ NON_SECURE = 1,
+ HTTP_SHOW_WARNING_ON_SENSITIVE_FIELDS = 2,
+ NON_SECURE_AFTER_EDITING = 3,
+ NON_SECURE_WHILE_INCOGNITO = 4,
+ NON_SECURE_WHILE_INCOGNITO_OR_EDITING = 5,
LAST_STATUS
};
« no previous file with comments | « chrome/browser/flag_descriptions.cc ('k') | components/security_state/core/switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698