Add new mark-non-secure-as options to chrome://flags

chrome/browser/flag_descriptions.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/flag_descriptions.h"
 
 namespace flag_descriptions {
 
 //  Material Design version of chrome://bookmarks
 
@@ skipping 153 matching lines @@
     "Show in-form warnings for sensitive fields when the top-level page is "
     "not HTTPS";
 
 const char kEnableHttpFormWarningDescription[] =
     "Attaches a warning UI to any password or credit card fields detected "
     "when the top-level page is not HTTPS";
 
 const char kMarkHttpAsName[] = "Mark non-secure origins as non-secure";
 
 const char kMarkHttpAsDescription[] = "Change the UI treatment for HTTP pages";
-
 const char kMarkHttpAsDangerous[] = "Always mark HTTP as actively dangerous";
+const char kMarkHttpAsNonSecureWhileEditing[] =
+    "Warn on HTTP while editing forms";

[estark, 2017/05/30 22:46:42]

nit: description makes it sound like the warning will go away when you stop
editing. Maybe "Warn on HTTP pages for which the user has edited form fields" or
something like that?

[elawrence, 2017/05/30 23:47:07]

Would "Warn on HTTP after editing forms" resolve the concern?

+const char kMarkHttpAsNonSecureWhileIncognito[] =
+    "Warn on HTTP while in Incognito mode";
+const char kMarkHttpAsNonSecureWhileIncognitoOrEditing[] =
+    "Warn on HTTP while editing forms or in Incognito mode";
 
 //  Material design of the Incognito NTP.
 
 extern const char kMaterialDesignIncognitoNTPName[] =
     "Material Design Incognito NTP.";
 
 extern const char kMaterialDesignIncognitoNTPDescription[] =
     "If enabled, the Incognito New Tab page uses the new material design "
     "with a better readable text.";
 
@@ skipping 3030 matching lines @@
 
 const char kDisableNewVirtualKeyboardBehaviorName[] =
     "New window behavior for the accessibility keyboard";
 const char kDisableNewVirtualKeyboardBehaviorDescription[] =
     "Disable new window behavior for the accessibility keyboard "
     "in non-sticky mode (do not change work area in non-sticky mode).";
 
 #endif  // defined(OS_CHROMEOS)
 
 }  // namespace flag_descriptions