Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2907153003: VR: Add URL bar security-related coloring and emphasis. (Closed)

Created:
3 years, 6 months ago by cjgrant
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

VR: Add URL bar security-related coloring and emphasis. - Use url_formatter to format the URL string (eg. chop off http://) - Use code similar to OmniboxView to emphasize and color the string. BUG=722861 Review-Url: https://codereview.chromium.org/2902783002 Cr-Original-Commit-Position: refs/heads/master@{#475065} Review-Url: https://codereview.chromium.org/2907153003 . Cr-Commit-Position: refs/branch-heads/3112@{#15} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/f2f7f8ae486a6a97b387de5306b5a851349b5808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -37 lines) Patch
M chrome/browser/android/vr_shell/BUILD.gn View 3 chunks +4 lines, -0 lines 0 comments Download
A chrome/browser/android/vr_shell/textures/render_text_wrapper.h View 1 chunk +36 lines, -0 lines 0 comments Download
A chrome/browser/android/vr_shell/textures/render_text_wrapper.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture.h View 4 chunks +16 lines, -3 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture.cc View 7 chunks +128 lines, -25 lines 0 comments Download
A chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc View 1 chunk +97 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/url_bar.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/url_bar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/ui_interface.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_gl_thread.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_gl_thread.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
cjgrant
3 years, 6 months ago (2017-05-29 18:43:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f2f7f8ae486a6a97b387de5306b5a851349b5808.

Powered by Google App Engine
This is Rietveld 408576698