Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2902783002: VR: Add URL bar security-related coloring and emphasis. (Closed)

Created:
3 years, 7 months ago by cjgrant
Modified:
3 years, 7 months ago
Reviewers:
Ian Vollick, lgarron, estark
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Add URL bar security-related coloring and emphasis. - Use url_formatter to format the URL string (eg. chop off http://) - Use code similar to OmniboxView to emphasize and color the string. BUG=722861 Review-Url: https://codereview.chromium.org/2902783002 Cr-Commit-Position: refs/heads/master@{#475065} Committed: https://chromium.googlesource.com/chromium/src/+/6f0095b330f52533f1cad17bb6df7f4480eadf0e

Patch Set 1 #

Patch Set 2 : Purge a couple bits of unused code. #

Patch Set 3 : Tweak the back button icon size to match UX mocks. #

Total comments: 9

Patch Set 4 : Add an emphasis test base class and initial cases. #

Patch Set 5 : Fix rebase; add a "data" scheme test case. #

Patch Set 6 : Another test case for HTTPS + not secure. #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -37 lines) Patch
M chrome/browser/android/vr_shell/BUILD.gn View 1 2 3 3 chunks +4 lines, -0 lines 0 comments Download
A chrome/browser/android/vr_shell/textures/render_text_wrapper.h View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
A chrome/browser/android/vr_shell/textures/render_text_wrapper.cc View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture.h View 1 2 3 4 chunks +16 lines, -3 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture.cc View 1 2 3 4 7 chunks +128 lines, -25 lines 4 comments Download
A chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc View 1 2 3 4 5 1 chunk +97 lines, -0 lines 2 comments Download
M chrome/browser/android/vr_shell/ui_elements/url_bar.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/url_bar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/ui_interface.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.h View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_gl_thread.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_gl_thread.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (8 generated)
cjgrant
estark@ and lgarron@, please see the relevant changes in: chrome/browser/android/vr_shell/textures/url_bar_texture.cc A subsequent change may split ...
3 years, 7 months ago (2017-05-23 18:35:41 UTC) #2
estark
https://codereview.chromium.org/2902783002/diff/40001/chrome/browser/android/vr_shell/textures/url_bar_texture.cc File chrome/browser/android/vr_shell/textures/url_bar_texture.cc (right): https://codereview.chromium.org/2902783002/diff/40001/chrome/browser/android/vr_shell/textures/url_bar_texture.cc#newcode262 chrome/browser/android/vr_shell/textures/url_bar_texture.cc:262: // This method replicates behavior in OmniboxView::UpdateTextStyle(), and Would ...
3 years, 7 months ago (2017-05-24 01:11:07 UTC) #3
cjgrant
Thanks for taking a look Emily! See responses... https://codereview.chromium.org/2902783002/diff/40001/chrome/browser/android/vr_shell/textures/url_bar_texture.cc File chrome/browser/android/vr_shell/textures/url_bar_texture.cc (right): https://codereview.chromium.org/2902783002/diff/40001/chrome/browser/android/vr_shell/textures/url_bar_texture.cc#newcode262 chrome/browser/android/vr_shell/textures/url_bar_texture.cc:262: // ...
3 years, 7 months ago (2017-05-24 17:40:58 UTC) #4
cjgrant
https://codereview.chromium.org/2902783002/diff/40001/chrome/browser/android/vr_shell/textures/url_bar_texture.cc File chrome/browser/android/vr_shell/textures/url_bar_texture.cc (right): https://codereview.chromium.org/2902783002/diff/40001/chrome/browser/android/vr_shell/textures/url_bar_texture.cc#newcode262 chrome/browser/android/vr_shell/textures/url_bar_texture.cc:262: // This method replicates behavior in OmniboxView::UpdateTextStyle(), and On ...
3 years, 7 months ago (2017-05-25 00:50:59 UTC) #5
estark
Thanks. I'm glad to hear tests are in the works. I left a few more ...
3 years, 7 months ago (2017-05-25 01:28:33 UTC) #6
cjgrant
https://codereview.chromium.org/2902783002/diff/40001/chrome/browser/android/vr_shell/textures/url_bar_texture.cc File chrome/browser/android/vr_shell/textures/url_bar_texture.cc (right): https://codereview.chromium.org/2902783002/diff/40001/chrome/browser/android/vr_shell/textures/url_bar_texture.cc#newcode255 chrome/browser/android/vr_shell/textures/url_bar_texture.cc:255: render_text->SetElideBehavior(gfx::TRUNCATE); On 2017/05/25 01:28:32, estark wrote: > Does this ...
3 years, 7 months ago (2017-05-25 01:55:28 UTC) #7
estark
On 2017/05/25 01:55:28, cjgrant wrote: > https://codereview.chromium.org/2902783002/diff/40001/chrome/browser/android/vr_shell/textures/url_bar_texture.cc > File chrome/browser/android/vr_shell/textures/url_bar_texture.cc (right): > > https://codereview.chromium.org/2902783002/diff/40001/chrome/browser/android/vr_shell/textures/url_bar_texture.cc#newcode255 > ...
3 years, 7 months ago (2017-05-25 02:47:34 UTC) #8
cjgrant
On 2017/05/25 02:47:34, estark wrote: > On 2017/05/25 01:55:28, cjgrant wrote: > > > https://codereview.chromium.org/2902783002/diff/40001/chrome/browser/android/vr_shell/textures/url_bar_texture.cc ...
3 years, 7 months ago (2017-05-25 18:31:18 UTC) #9
Ian Vollick
On 2017/05/25 18:31:18, cjgrant wrote: > On 2017/05/25 02:47:34, estark wrote: > > On 2017/05/25 ...
3 years, 7 months ago (2017-05-25 18:52:58 UTC) #10
estark
On 2017/05/25 18:31:18, cjgrant wrote: > On 2017/05/25 02:47:34, estark wrote: > > On 2017/05/25 ...
3 years, 7 months ago (2017-05-25 20:51:21 UTC) #11
Ian Vollick
lgtm w/ some nits. https://codereview.chromium.org/2902783002/diff/100001/chrome/browser/android/vr_shell/textures/url_bar_texture.cc File chrome/browser/android/vr_shell/textures/url_bar_texture.cc (right): https://codereview.chromium.org/2902783002/diff/100001/chrome/browser/android/vr_shell/textures/url_bar_texture.cc#newcode93 chrome/browser/android/vr_shell/textures/url_bar_texture.cc:93: if (range.IsValid()) { OOC, when ...
3 years, 7 months ago (2017-05-26 01:22:19 UTC) #12
cjgrant
https://codereview.chromium.org/2902783002/diff/40001/chrome/browser/android/vr_shell/textures/url_bar_texture.cc File chrome/browser/android/vr_shell/textures/url_bar_texture.cc (right): https://codereview.chromium.org/2902783002/diff/40001/chrome/browser/android/vr_shell/textures/url_bar_texture.cc#newcode283 chrome/browser/android/vr_shell/textures/url_bar_texture.cc:283: // TODO(cjgrant): Handle extensions, if required, for desktop. On ...
3 years, 7 months ago (2017-05-26 15:58:59 UTC) #13
Ian Vollick
On 2017/05/26 15:58:59, cjgrant wrote: > https://codereview.chromium.org/2902783002/diff/40001/chrome/browser/android/vr_shell/textures/url_bar_texture.cc > File chrome/browser/android/vr_shell/textures/url_bar_texture.cc (right): > > https://codereview.chromium.org/2902783002/diff/40001/chrome/browser/android/vr_shell/textures/url_bar_texture.cc#newcode283 > ...
3 years, 7 months ago (2017-05-26 16:28:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902783002/100001
3 years, 7 months ago (2017-05-26 17:43:06 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 18:27:51 UTC) #23
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/6f0095b330f52533f1cad17bb6df...

Powered by Google App Engine
This is Rietveld 408576698