Add support for Brazil Elo card in autofill.

Add support for Brazil Elo card in autofill.

Some additionals:
- Changed Dinners Club and MIR bin range according to the lastest wiki.
- Changed out-of-date website links
- For credit_card_unittest, the upper limit for INSTANTIATE_TEST_CASE_P is 50 cases according to [1], so did not add more coverage for the numbers.

BUG=709551
TEST=components:components_unittests

Unrelated presubmit script errors: 
owners.SyntaxErrorInOwnersFile: /usr/local/google/git/chrome/chromium/src/components/resources/OWNERS:24 syntax error: components/sync/OWNERS does not refer to an existing file.

NOPRESUBMIT=true

[1] https://cs.chromium.org/chromium/src/third_party/mesa/src/src/gtest/include/gtest/gtest-param-test.h?q=gtest-param-test.h+package:%5Echromium$&dr=C&l=1190

Review-Url: https://codereview.chromium.org/2906763005
Cr-Commit-Position: refs/heads/master@{#476334}
Committed: https://chromium.googlesource.com/chromium/src/+/fa8183309600f1c2b8c4ad5a60aee69761916a9e

[jiahuiguo, 2017-05-26 03:34:49]

The CQ bit was checked by jiahuiguo@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 03:35:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 03:39:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 03:39:31]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jiahuiguo, 2017-05-26 03:40:38]

Description was changed from

==========
Add support for Brazil Elo card in autofill.

BUG=709551
==========

to

==========
Add support for Brazil Elo card in autofill.

Some additionals:
- Changed Dinners Club and MIR bin range according to the lastest wiki.
- Changed out-of-date website links
- For credit_card_unittest, the upper limit for INSTANTIATE_TEST_CASE_P is 50
cases according to [1], so did not add more coverage for the numbers.

BUG=709551
TEST=components:components_unittests


[1]
https://cs.chromium.org/chromium/src/third_party/mesa/src/src/gtest/include/g...
==========

[jiahuiguo, 2017-05-26 03:54:59]

jiahuiguo@google.com changed reviewers:
+ jsaul@google.com, mathp@chromium.org

[jiahuiguo, 2017-05-26 03:55:00]

Hi Jared and Mathieu,

PTAL, some details about ELO bin range handle and xml/png, please refer to the
bug: crbug/709551.

[Mathieu, 2017-05-26 13:48:32]

Very good work! Just a few comments

https://codereview.chromium.org/2906763005/diff/1/chrome/browser/ui/autofill/...
File chrome/browser/ui/autofill/autofill_popup_layout_model.cc (right):

https://codereview.chromium.org/2906763005/diff/1/chrome/browser/ui/autofill/...
chrome/browser/ui/autofill/autofill_popup_layout_model.cc:52:
{"americanExpressCC", IDR_AUTOFILL_CC_AMEX},
let's use the constants from CreditCard i.e. kAmericanExpressCard

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_data_util.cc (right):

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_data_util.cc:29: {"americanExpressCC",
"amex", IDR_AUTOFILL_CC_AMEX, IDS_AUTOFILL_CC_AMEX},
you'll need to rebase, these are now constants

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
File components/autofill/core/browser/credit_card.cc (right):

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/credit_card.cc:953: //
WebKitPlatformSupportImpl to load the image data.
that seems... out of date. Can we remove this comment?

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
File components/autofill/core/browser/credit_card_unittest.cc (right):

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/credit_card_unittest.cc:415: #if
!defined(OS_IOS)
can you try removing this to see if it works?

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/credit_card_unittest.cc:675:
INSTANTIATE_TEST_CASE_P(
You can have an additional "batch" if you're hitting the 50 limit

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/credit_card_unittest.cc:767:
GetCardNetworkTestCase{"2200", kMirCard, false},
can we have a mastercard that starts with 2

[jiahuiguo, 2017-05-26 19:42:45]

The CQ bit was checked by jiahuiguo@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 19:43:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jiahuiguo, 2017-05-26 19:44:10]

Hi Jared and Mathieu,

PTAL the code and the bin range pattern in the bug.

Thanks.

https://codereview.chromium.org/2906763005/diff/1/chrome/browser/ui/autofill/...
File chrome/browser/ui/autofill/autofill_popup_layout_model.cc (right):

https://codereview.chromium.org/2906763005/diff/1/chrome/browser/ui/autofill/...
chrome/browser/ui/autofill/autofill_popup_layout_model.cc:52:
{"americanExpressCC", IDR_AUTOFILL_CC_AMEX},
On 2017/05/26 13:48:32, Mathieu wrote:
> let's use the constants from CreditCard i.e. kAmericanExpressCard

Done.

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_data_util.cc (right):

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_data_util.cc:29: {"americanExpressCC",
"amex", IDR_AUTOFILL_CC_AMEX, IDS_AUTOFILL_CC_AMEX},
On 2017/05/26 13:48:32, Mathieu wrote:
> you'll need to rebase, these are now constants

Done.

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
File components/autofill/core/browser/credit_card.cc (right):

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/credit_card.cc:953: //
WebKitPlatformSupportImpl to load the image data.
On 2017/05/26 13:48:32, Mathieu wrote:
> that seems... out of date. Can we remove this comment?

Yeah, I search the WebKitPlatformSupportImpl in cs, did not found any related
files.

https://cs.chromium.org/search/?q=WebKitPlatformSupportImpl+package:%5Echromi...

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
File components/autofill/core/browser/credit_card_unittest.cc (right):

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/credit_card_unittest.cc:415: #if
!defined(OS_IOS)
On 2017/05/26 13:48:32, Mathieu wrote:
> can you try removing this to see if it works?

Done, will verify using trybot.

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/credit_card_unittest.cc:675:
INSTANTIATE_TEST_CASE_P(
On 2017/05/26 13:48:32, Mathieu wrote:
> You can have an additional "batch" if you're hitting the 50 limit

Acknowledged.

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/credit_card_unittest.cc:767:
GetCardNetworkTestCase{"2200", kMirCard, false},
On 2017/05/26 13:48:32, Mathieu wrote:
> can we have a mastercard that starts with 2

Done.

[commit-bot: I haz the power, 2017-05-26 19:50:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 19:50:39]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jared Saul, 2017-05-26 19:51:10]

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
File components/autofill/core/browser/credit_card.cc (left):

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/credit_card.cc:171: //
http://www.discovernetwork.com/merchants/images/Merchant_Marketing_PDF.pdf,
These two are removed entirely, but I wonder if they should stick around?  Even
though the Discover link is broken, it makes it clear we once got some of the
data (which is still here) from Discover itself, and we'll lose that if the line
is deleted.

In fact, I found a cached version of it:
https://web.archive.org/web/20120417005304/http://www.discovernetwork.com/mer...

The comment itself mentions that "beachnet is unavailable, but here's the cached
version", so maybe move the discovernetwork link down there and update to match.

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
File components/autofill/core/browser/credit_card.cc (right):

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/credit_card.cc:191: // Maestro               
50,56-58,6                                 12-19
Maestro is not represented in the rules below, and it also conflicts with some
of the other rules, which is confusing.  Maybe change to "Maestro
(unsupported)"?

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/credit_card.cc:277: first_six_digits == 627780)
Reverse line order: 627780 < 636297

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
File components/autofill/core/browser/validation.cc (right):

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/validation.cc:52: // [1]
http://www.merriampark.com/anatomycc.htm
This link is broken; the last known good snapshot was June 2012:
https://web.archive.org/web/20120614072656/http://www.merriampark.com/anatomy...

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/validation.cc:53: // [2]
http://en.wikipedia.org/wiki/Bank_card_number
This has also changed to Payment_card_number; update link?

[Mathieu, 2017-05-29 15:54:31]

Thanks a lot! lgtm.

I think we'll want to merge to M60, too. 

This is good to go once Jared is satisfied too.

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
File components/autofill/core/browser/credit_card.cc (right):

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/credit_card.cc:191: // Maestro               
50,56-58,6                                 12-19
On 2017/05/26 19:51:10, Jared Saul wrote:
> Maestro is not represented in the rules below, and it also conflicts with some
> of the other rules, which is confusing.  Maybe change to "Maestro
> (unsupported)"? 

Should Maestro be supported one day? I'm not too familiar with it and if it's
better to display Maestro vs Mastercard.

https://codereview.chromium.org/2906763005/diff/20001/chrome/browser/ui/autof...
File chrome/browser/ui/autofill/autofill_popup_layout_model.cc (right):

https://codereview.chromium.org/2906763005/diff/20001/chrome/browser/ui/autof...
chrome/browser/ui/autofill/autofill_popup_layout_model.cc:53: {kDinersCard,
IDR_AUTOFILL_CC_GENERIC},
yikes, there's a few errors from before your patch here! This should be
IDR_AUTOFILL_CC_DINERS, for example (same with JCB). Can you change and verify
visually that it is correct (Enter a Diners card and use it in the Autofill
dropdown on Desktop)?

[jiahuiguo, 2017-05-29 20:08:06]

Thanks for the comments, PTAL.

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
File components/autofill/core/browser/credit_card.cc (left):

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/credit_card.cc:171: //
http://www.discovernetwork.com/merchants/images/Merchant_Marketing_PDF.pdf,
On 2017/05/26 19:51:10, Jared Saul wrote:
> These two are removed entirely, but I wonder if they should stick around? 
Even
> though the Discover link is broken, it makes it clear we once got some of the
> data (which is still here) from Discover itself, and we'll lose that if the
line
> is deleted.
> 
> In fact, I found a cached version of it:
>
https://web.archive.org/web/20120417005304/http://www.discovernetwork.com/mer...
> 
> The comment itself mentions that "beachnet is unavailable, but here's the
cached
> version", so maybe move the discovernetwork link down there and update to
match.

Ha, this is a good point! But I wonder since they are obsolete and later
developers may never need to take a look back where where they come from
(because only the latest info is interesting to us). When I try to update the
list, all I care about is when this is last updated.

Will it be better if we only keep a valid set and mark the last updated date?

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
File components/autofill/core/browser/credit_card.cc (right):

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/credit_card.cc:191: // Maestro               
50,56-58,6                                 12-19
On 2017/05/29 15:54:31, Mathieu wrote:
> On 2017/05/26 19:51:10, Jared Saul wrote:
> > Maestro is not represented in the rules below, and it also conflicts with
some
> > of the other rules, which is confusing.  Maybe change to "Maestro
> > (unsupported)"? 
> 
> Should Maestro be supported one day? I'm not too familiar with it and if it's
> better to display Maestro vs Mastercard. 

Payments platform now support this card type, we have needed resource icons. And
actually its bin range does not overlap with Mastercard. Will remove this now
and add later if we want it.

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/credit_card.cc:277: first_six_digits == 627780)
On 2017/05/26 19:51:10, Jared Saul wrote:
> Reverse line order: 627780 < 636297

Nice catch! Thanks.

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
File components/autofill/core/browser/validation.cc (right):

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/validation.cc:52: // [1]
http://www.merriampark.com/anatomycc.htm
On 2017/05/26 19:51:10, Jared Saul wrote:
> This link is broken; the last known good snapshot was June 2012:
>
https://web.archive.org/web/20120614072656/http://www.merriampark.com/anatomy...

The link in wiki is sufficient I believe, and noted the last updated date.

https://codereview.chromium.org/2906763005/diff/1/components/autofill/core/br...
components/autofill/core/browser/validation.cc:53: // [2]
http://en.wikipedia.org/wiki/Bank_card_number
On 2017/05/26 19:51:10, Jared Saul wrote:
> This has also changed to Payment_card_number; update link?

Done.

https://codereview.chromium.org/2906763005/diff/20001/chrome/browser/ui/autof...
File chrome/browser/ui/autofill/autofill_popup_layout_model.cc (right):

https://codereview.chromium.org/2906763005/diff/20001/chrome/browser/ui/autof...
chrome/browser/ui/autofill/autofill_popup_layout_model.cc:53: {kDinersCard,
IDR_AUTOFILL_CC_GENERIC},
On 2017/05/29 15:54:31, Mathieu wrote:
> yikes, there's a few errors from before your patch here! This should be
> IDR_AUTOFILL_CC_DINERS, for example (same with JCB). Can you change and verify
> visually that it is correct (Enter a Diners card and use it in the Autofill
> dropdown on Desktop)?

Done.

[jiahuiguo, 2017-05-29 23:19:43]

The CQ bit was checked by jiahuiguo@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 23:19:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jiahuiguo, 2017-05-29 23:20:49]

The CQ bit was unchecked by jiahuiguo@google.com

[jiahuiguo, 2017-05-29 23:51:56]

The CQ bit was checked by jiahuiguo@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 23:52:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 23:59:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 23:59:43]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jiahuiguo, 2017-05-30 03:18:56]

The CQ bit was checked by jiahuiguo@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 03:19:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 03:27:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 03:27:10]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jiahuiguo, 2017-05-31 01:18:14]

jiahuiguo@google.com changed reviewers:
+ tedchoc@chromium.org

[jiahuiguo, 2017-05-31 01:18:14]

Hi Ted, PTAL.

Thanks.

[Jared Saul, 2017-05-31 18:26:23]

lgtm

https://codereview.chromium.org/2906763005/diff/80001/chrome/browser/ui/autof...
File chrome/browser/ui/autofill/autofill_popup_layout_model.cc (right):

https://codereview.chromium.org/2906763005/diff/80001/chrome/browser/ui/autof...
chrome/browser/ui/autofill/autofill_popup_layout_model.cc:54:
{autofill::kDinersCard, IDR_AUTOFILL_CC_DINERS},
Diners and JCB were both using "IDR_AUTOFILL_CC_GENERIC" but now they're not. 
Was this intended?

[Mathieu, 2017-05-31 18:27:24]

https://codereview.chromium.org/2906763005/diff/80001/chrome/browser/ui/autof...
File chrome/browser/ui/autofill/autofill_popup_layout_model.cc (right):

https://codereview.chromium.org/2906763005/diff/80001/chrome/browser/ui/autof...
chrome/browser/ui/autofill/autofill_popup_layout_model.cc:54:
{autofill::kDinersCard, IDR_AUTOFILL_CC_DINERS},
On 2017/05/31 18:26:23, Jared Saul wrote:
> Diners and JCB were both using "IDR_AUTOFILL_CC_GENERIC" but now they're not. 
> Was this intended?

I asked Jason to fix the bug. I updated the assets, but probably forgot to add
them here.

[jiahuiguo, 2017-05-31 18:27:56]

Thanks.

https://codereview.chromium.org/2906763005/diff/80001/chrome/browser/ui/autof...
File chrome/browser/ui/autofill/autofill_popup_layout_model.cc (right):

https://codereview.chromium.org/2906763005/diff/80001/chrome/browser/ui/autof...
chrome/browser/ui/autofill/autofill_popup_layout_model.cc:54:
{autofill::kDinersCard, IDR_AUTOFILL_CC_DINERS},
On 2017/05/31 18:26:23, Jared Saul wrote:
> Diners and JCB were both using "IDR_AUTOFILL_CC_GENERIC" but now they're not. 
> Was this intended?

Yep, it was a previous bug.

[Ted C, 2017-05-31 18:46:30]

lgtm

[jiahuiguo, 2017-06-01 15:57:01]

Description was changed from

==========
Add support for Brazil Elo card in autofill.

Some additionals:
- Changed Dinners Club and MIR bin range according to the lastest wiki.
- Changed out-of-date website links
- For credit_card_unittest, the upper limit for INSTANTIATE_TEST_CASE_P is 50
cases according to [1], so did not add more coverage for the numbers.

BUG=709551
TEST=components:components_unittests


[1]
https://cs.chromium.org/chromium/src/third_party/mesa/src/src/gtest/include/g...
==========

to

==========
Add support for Brazil Elo card in autofill.

Some additionals:
- Changed Dinners Club and MIR bin range according to the lastest wiki.
- Changed out-of-date website links
- For credit_card_unittest, the upper limit for INSTANTIATE_TEST_CASE_P is 50
cases according to [1], so did not add more coverage for the numbers.

BUG=709551
TEST=components:components_unittests

Unrelated presubmit script errors: 
owners.SyntaxErrorInOwnersFile:
/usr/local/google/git/chrome/chromium/src/components/resources/OWNERS:24 syntax
error: components/sync/OWNERS does not refer to an existing file.

NOPRESUBMIT=true

[1]
https://cs.chromium.org/chromium/src/third_party/mesa/src/src/gtest/include/g...
==========

[jiahuiguo, 2017-06-01 16:00:30]

The CQ bit was checked by jiahuiguo@google.com

[jiahuiguo, 2017-06-01 16:00:31]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2906763005/#ps80001
(title: "Fix test")

[commit-bot: I haz the power, 2017-06-01 16:00:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 17:09:48]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496332830433030,
"parent_rev": "2657632ce7da40b8cb1de9d5e09ee7f1a36799d0", "commit_rev":
"fa8183309600f1c2b8c4ad5a60aee69761916a9e"}

[commit-bot: I haz the power, 2017-06-01 17:09:58]

Description was changed from

==========
Add support for Brazil Elo card in autofill.

Some additionals:
- Changed Dinners Club and MIR bin range according to the lastest wiki.
- Changed out-of-date website links
- For credit_card_unittest, the upper limit for INSTANTIATE_TEST_CASE_P is 50
cases according to [1], so did not add more coverage for the numbers.

BUG=709551
TEST=components:components_unittests

Unrelated presubmit script errors: 
owners.SyntaxErrorInOwnersFile:
/usr/local/google/git/chrome/chromium/src/components/resources/OWNERS:24 syntax
error: components/sync/OWNERS does not refer to an existing file.

NOPRESUBMIT=true

[1]
https://cs.chromium.org/chromium/src/third_party/mesa/src/src/gtest/include/g...
==========

to

==========
Add support for Brazil Elo card in autofill.

Some additionals:
- Changed Dinners Club and MIR bin range according to the lastest wiki.
- Changed out-of-date website links
- For credit_card_unittest, the upper limit for INSTANTIATE_TEST_CASE_P is 50
cases according to [1], so did not add more coverage for the numbers.

BUG=709551
TEST=components:components_unittests

Unrelated presubmit script errors: 
owners.SyntaxErrorInOwnersFile:
/usr/local/google/git/chrome/chromium/src/components/resources/OWNERS:24 syntax
error: components/sync/OWNERS does not refer to an existing file.

NOPRESUBMIT=true

[1]
https://cs.chromium.org/chromium/src/third_party/mesa/src/src/gtest/include/g...

Review-Url: https://codereview.chromium.org/2906763005
Cr-Commit-Position: refs/heads/master@{#476334}
Committed:
https://chromium.googlesource.com/chromium/src/+/fa8183309600f1c2b8c4ad5a60ae...
==========

[commit-bot: I haz the power, 2017-06-01 17:10:02]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/fa8183309600f1c2b8c4ad5a60ae...