Add support for Brazil Elo card in autofill.

components/autofill/core/browser/credit_card.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/credit_card.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 61 matching lines @@
   return false;
 }
 
 base::string16 NetworkForFill(const std::string& network) {
   if (network == kAmericanExpressCard)
     return l10n_util::GetStringUTF16(IDS_AUTOFILL_CC_AMEX);
   if (network == kDinersCard)
     return l10n_util::GetStringUTF16(IDS_AUTOFILL_CC_DINERS);
   if (network == kDiscoverCard)
     return l10n_util::GetStringUTF16(IDS_AUTOFILL_CC_DISCOVER);
+  if (network == kEloCard)
+    return l10n_util::GetStringUTF16(IDS_AUTOFILL_CC_ELO);
   if (network == kJCBCard)
     return l10n_util::GetStringUTF16(IDS_AUTOFILL_CC_JCB);
   if (network == kMasterCard)
     return l10n_util::GetStringUTF16(IDS_AUTOFILL_CC_MASTERCARD);
   if (network == kMirCard)
     return l10n_util::GetStringUTF16(IDS_AUTOFILL_CC_MIR);
   if (network == kUnionPay)
     return l10n_util::GetStringUTF16(IDS_AUTOFILL_CC_UNION_PAY);
   if (network == kVisaCard)
     return l10n_util::GetStringUTF16(IDS_AUTOFILL_CC_VISA);
@@ skipping 47 matching lines @@
 }
 
 // static
 int CreditCard::IconResourceId(const std::string& network) {
   if (network == kAmericanExpressCard)
     return IDR_AUTOFILL_CC_AMEX;
   if (network == kDinersCard)
     return IDR_AUTOFILL_CC_DINERS;
   if (network == kDiscoverCard)
     return IDR_AUTOFILL_CC_DISCOVER;
+  if (network == kEloCard)
+    return IDR_AUTOFILL_CC_ELO;
   if (network == kJCBCard)
     return IDR_AUTOFILL_CC_JCB;
   if (network == kMasterCard)
     return IDR_AUTOFILL_CC_MASTERCARD;
   if (network == kMirCard)
     return IDR_AUTOFILL_CC_MIR;
   if (network == kUnionPay)
     return IDR_AUTOFILL_CC_UNIONPAY;
   if (network == kVisaCard)
     return IDR_AUTOFILL_CC_VISA;
 
   // If you hit this DCHECK, the above list of cases needs to be updated to
   // include a new card.
   DCHECK_EQ(kGenericCard, network);
   return IDR_AUTOFILL_CC_GENERIC;
 }
 
 // static
 const char* CreditCard::GetCardNetwork(const base::string16& number) {
   // Credit card number specifications taken from:
-  // http://en.wikipedia.org/wiki/Credit_card_numbers,
-  // http://en.wikipedia.org/wiki/List_of_Issuer_Identification_Numbers,
-  // http://www.discovernetwork.com/merchants/images/Merchant_Marketing_PDF.pdf,

[Jared Saul, 2017/05/26 19:51:10]

These two are removed entirely, but I wonder if they should stick around?  Even
though the Discover link is broken, it makes it clear we once got some of the
data (which is still here) from Discover itself, and we'll lose that if the line
is deleted.

In fact, I found a cached version of it:
https://web.archive.org/web/20120417005304/http://www.discovernetwork.com/mer...

The comment itself mentions that "beachnet is unavailable, but here's the cached
version", so maybe move the discovernetwork link down there and update to match.

[jiahuiguo, 2017/05/29 20:08:05]

Ha, this is a good point! But I wonder since they are obsolete and later
developers may never need to take a look back where where they come from
(because only the latest info is interesting to us). When I try to update the
list, all I care about is when this is last updated.

Will it be better if we only keep a valid set and mark the last updated date?

+  // https://en.wikipedia.org/wiki/Payment_card_number,
   // http://www.regular-expressions.info/creditcard.html,
-  // http://developer.ean.com/general_info/Valid_Credit_Card_Types,
+  // https://developer.ean.com/general-info/valid-card-types,
   // http://www.bincodes.com/,
   // http://www.fraudpractice.com/FL-binCC.html, and
   // http://www.beachnet.com/~hstiles/cardtype.html
   //
   // The last site is currently unavailable, but a cached version remains at
   // http://web.archive.org/web/20120923111349/http://www.beachnet.com/~hstiles/cardtype.html
   //
-  // Card Type              Prefix(es)                      Length
-  // ---------------------------------------------------------------
-  // Visa                   4                               13,16
-  // American Express       34,37                           15
-  // Diners Club            300-305,3095,36,38-39           14
-  // Discover Card          6011,644-649,65                 16
-  // JCB                    3528-3589                       16
-  // Mastercard             51-55                           16
-  // UnionPay               62                              16-19
+  // Card Type              Prefix(es)                                  Length
+  // --------------------------------------------------------------------------
+  // Visa                   4                                          13,16,19
+  // American Express       34,37                                      15
+  // Diners Club            300-305,309,36,38-39                       14
+  // Discover Card          6011,644-649,65                            16
+  // Elo                    431274,451416,5067,5090,627780,636297      16
+  // JCB                    3528-3589                                  16
+  // Maestro                50,56-58,6                                 12-19

[Jared Saul, 2017/05/26 19:51:10]

Maestro is not represented in the rules below, and it also conflicts with some
of the other rules, which is confusing.  Maybe change to "Maestro
(unsupported)"? 

[Mathieu, 2017/05/29 15:54:31]

Should Maestro be supported one day? I'm not too familiar with it and if it's
better to display Maestro vs Mastercard. 

[jiahuiguo, 2017/05/29 20:08:06]

Payments platform now support this card type, we have needed resource icons. And
actually its bin range does not overlap with Mastercard. Will remove this now
and add later if we want it.

+  // Mastercard             2221-2720, 51-55                           16
+  // MIR                    2200-2204                                  16
+  // UnionPay               62                                         16-19
 
   // Check for prefixes of length 1.
   if (number.empty())
     return kGenericCard;
 
   if (number[0] == '4')
     return kVisaCard;
 
   // Check for prefixes of length 2.
   if (number.size() < 2)
     return kGenericCard;
 
   int first_two_digits = 0;
   if (!base::StringToInt(number.substr(0, 2), &first_two_digits))
     return kGenericCard;
 
-  if (first_two_digits == 22)
-    return kMirCard;
-
   if (first_two_digits == 34 || first_two_digits == 37)
     return kAmericanExpressCard;
 
   if (first_two_digits == 36 ||
       first_two_digits == 38 ||
       first_two_digits == 39)
     return kDinersCard;
 
   if (first_two_digits >= 51 && first_two_digits <= 55)
     return kMasterCard;
 
   if (first_two_digits == 62)
     return kUnionPay;
 
   if (first_two_digits == 65)
     return kDiscoverCard;
 
   // Check for prefixes of length 3.
   if (number.size() < 3)
     return kGenericCard;
 
   int first_three_digits = 0;
   if (!base::StringToInt(number.substr(0, 3), &first_three_digits))
     return kGenericCard;
 
-  if (first_three_digits >= 300 && first_three_digits <= 305)
+  if ((first_three_digits >= 300 && first_three_digits <= 305) ||
+      first_three_digits == 309)
     return kDinersCard;
 
   if (first_three_digits >= 644 && first_three_digits <= 649)
     return kDiscoverCard;
 
   // Check for prefixes of length 4.
   if (number.size() < 4)
     return kGenericCard;
 
   int first_four_digits = 0;
   if (!base::StringToInt(number.substr(0, 4), &first_four_digits))
     return kGenericCard;
 
-  if (first_four_digits == 3095)
-    return kDinersCard;
+  if (first_four_digits >= 2200 && first_four_digits <= 2204)
+    return kMirCard;
+
+  if (first_four_digits >= 2221 && first_four_digits <= 2720)
+    return kMasterCard;
 
   if (first_four_digits >= 3528 && first_four_digits <= 3589)
     return kJCBCard;
 
+  if (first_four_digits == 5067 || first_four_digits == 5090)
+    return kEloCard;
+
   if (first_four_digits == 6011)
     return kDiscoverCard;
 
+  // Check for prefixes of length 6.
+  if (number.size() < 6)
+    return kGenericCard;
+
+  int first_six_digits = 0;
+  if (!base::StringToInt(number.substr(0, 6), &first_six_digits))
+    return kGenericCard;
+
+  if (first_six_digits == 431274 ||
+      first_six_digits == 451416 ||
+      first_six_digits == 636297 ||
+      first_six_digits == 627780)

[Jared Saul, 2017/05/26 19:51:10]

Reverse line order: 627780 < 636297

[jiahuiguo, 2017/05/29 20:08:06]

Nice catch! Thanks.

+    return kEloCard;
+
   return kGenericCard;
 }
 
 void CreditCard::SetNetworkForMaskedCard(base::StringPiece network) {
   DCHECK_EQ(MASKED_SERVER_CARD, record_type());
   network_ = network.as_string();
 }
 
 void CreditCard::SetServerStatus(ServerStatus status) {
   DCHECK_NE(LOCAL_CARD, record_type());
@@ skipping 653 matching lines @@
             << " "
             << base::UTF16ToUTF8(credit_card.GetRawInfo(CREDIT_CARD_NUMBER))
             << " "
             << base::UTF16ToUTF8(credit_card.GetRawInfo(CREDIT_CARD_EXP_MONTH))
             << " " << base::UTF16ToUTF8(
                           credit_card.GetRawInfo(CREDIT_CARD_EXP_4_DIGIT_YEAR));
 }
 
 // These values must match the values in WebKitPlatformSupportImpl in
 // webkit/glue. We send these strings to WebKit, which then asks
 // WebKitPlatformSupportImpl to load the image data.

[Mathieu, 2017/05/26 13:48:32]

that seems... out of date. Can we remove this comment?

[jiahuiguo, 2017/05/26 19:44:10]

Yeah, I search the WebKitPlatformSupportImpl in cs, did not found any related
files.

https://cs.chromium.org/search/?q=WebKitPlatformSupportImpl+package:%5Echromi...

 const char kAmericanExpressCard[] = "americanExpressCC";
 const char kDinersCard[] = "dinersCC";
 const char kDiscoverCard[] = "discoverCC";
+const char kEloCard[] = "eloCC";
 const char kGenericCard[] = "genericCC";
 const char kJCBCard[] = "jcbCC";
 const char kMasterCard[] = "masterCardCC";
 const char kMirCard[] = "mirCC";
 const char kUnionPay[] = "unionPayCC";
 const char kVisaCard[] = "visaCC";
 
 }  // namespace autofill