Add support for Brazil Elo card in autofill.

components/autofill/core/browser/credit_card_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/guid.h"
 #include "base/macros.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 35 matching lines @@
   "3530-1113-3330-0000",
   "3566002020360505",
   "5555 5555 5555 4444",
   "5105-1051-0510-5100",
   "4111111111111111",
   "4012 8888 8888 1881",
   "4222-2222-2222-2",
   "5019717010103742",
   "6331101999990016",
   "6247130048162403",
+  "4532261615476013542",
+  "6362970000457013",
 };
+
 const char* const kInvalidNumbers[] = {
   "4111 1111 112", /* too short */
   "41111111111111111115", /* too long */
   "4111-1111-1111-1110", /* wrong Luhn checksum */
   "3056 9309 0259 04aa", /* non-digit characters */
 };
 
 const char kUTF8MidlineEllipsis[] =
     "  "
     "\xE2\x80\xA2\xE2\x80\x86"
@@ skipping 335 matching lines @@
 
   // Different values produce non-zero results.
   test::SetCreditCardInfo(&a, "Jimmy", NULL, NULL, NULL, "");
   test::SetCreditCardInfo(&b, "Ringo", NULL, NULL, NULL, "");
   EXPECT_GT(0, a.Compare(b));
   EXPECT_LT(0, b.Compare(a));
 }
 
 // This method is not compiled for iOS because these resources are not used and
 // should not be shipped.
 #if !defined(OS_IOS)

[Mathieu, 2017/05/26 13:48:32]

can you try removing this to see if it works?

[jiahuiguo, 2017/05/26 19:44:10]

Done, will verify using trybot.

 // Test we get the correct icon for each card type.
 TEST(CreditCardTest, IconResourceId) {
   EXPECT_EQ(IDR_AUTOFILL_CC_AMEX,
             CreditCard::IconResourceId(kAmericanExpressCard));
   EXPECT_EQ(IDR_AUTOFILL_CC_DINERS,
             CreditCard::IconResourceId(kDinersCard));
   EXPECT_EQ(IDR_AUTOFILL_CC_DISCOVER,
             CreditCard::IconResourceId(kDiscoverCard));
+  EXPECT_EQ(IDR_AUTOFILL_CC_ELO,
+            CreditCard::IconResourceId(kEloCard));
   EXPECT_EQ(IDR_AUTOFILL_CC_JCB,
             CreditCard::IconResourceId(kJCBCard));
   EXPECT_EQ(IDR_AUTOFILL_CC_MASTERCARD,
             CreditCard::IconResourceId(kMasterCard));
   EXPECT_EQ(IDR_AUTOFILL_CC_MIR,
             CreditCard::IconResourceId(kMirCard));
   EXPECT_EQ(IDR_AUTOFILL_CC_UNIONPAY,
             CreditCard::IconResourceId(kUnionPay));
   EXPECT_EQ(IDR_AUTOFILL_CC_VISA,
             CreditCard::IconResourceId(kVisaCard));
@@ skipping 229 matching lines @@
     : public testing::TestWithParam<GetCardNetworkTestCase> {};
 
 TEST_P(GetCardNetworkTestBatch1, GetCardNetwork) {
   auto test_case = GetParam();
   base::string16 card_number = ASCIIToUTF16(test_case.card_number);
   SCOPED_TRACE(card_number);
   EXPECT_EQ(test_case.issuer_network, CreditCard::GetCardNetwork(card_number));
   EXPECT_EQ(test_case.is_valid, IsValidCreditCardNumber(card_number));
 }
 
 INSTANTIATE_TEST_CASE_P(

[Mathieu, 2017/05/26 13:48:32]

You can have an additional "batch" if you're hitting the 50 limit

[jiahuiguo, 2017/05/26 19:44:10]

Acknowledged.

     CreditCardTest,
     GetCardNetworkTestBatch1,
     testing::Values(
         // The relevant sample numbers from
         // http://www.paypalobjects.com/en_US/vhelp/paypalmanager_help/credit_card_numbers.htm
         GetCardNetworkTestCase{"378282246310005", kAmericanExpressCard, true},
         GetCardNetworkTestCase{"371449635398431", kAmericanExpressCard, true},
         GetCardNetworkTestCase{"378734493671000", kAmericanExpressCard, true},
         GetCardNetworkTestCase{"30569309025904", kDinersCard, true},
         GetCardNetworkTestCase{"38520000023237", kDinersCard, true},
         GetCardNetworkTestCase{"6011111111111117", kDiscoverCard, true},
         GetCardNetworkTestCase{"6011000990139424", kDiscoverCard, true},
         GetCardNetworkTestCase{"3530111333300000", kJCBCard, true},
         GetCardNetworkTestCase{"3566002020360505", kJCBCard, true},
         GetCardNetworkTestCase{"5555555555554444", kMasterCard, true},
         GetCardNetworkTestCase{"5105105105105100", kMasterCard, true},
         GetCardNetworkTestCase{"4111111111111111", kVisaCard, true},
         GetCardNetworkTestCase{"4012888888881881", kVisaCard, true},
         GetCardNetworkTestCase{"4222222222222", kVisaCard, true},
+        GetCardNetworkTestCase{"4532261615476013542", kVisaCard, true},
 
         // The relevant sample numbers from
         // https://www.auricsystems.com/sample-credit-card-numbers/
         GetCardNetworkTestCase{"343434343434343", kAmericanExpressCard, true},
         GetCardNetworkTestCase{"371144371144376", kAmericanExpressCard, true},
         GetCardNetworkTestCase{"341134113411347", kAmericanExpressCard, true},
         GetCardNetworkTestCase{"36438936438936", kDinersCard, true},
         GetCardNetworkTestCase{"36110361103612", kDinersCard, true},
         GetCardNetworkTestCase{"36111111111111", kDinersCard, true},
         GetCardNetworkTestCase{"6011016011016011", kDiscoverCard, true},
         GetCardNetworkTestCase{"6011000990139424", kDiscoverCard, true},
         GetCardNetworkTestCase{"6011000000000004", kDiscoverCard, true},
         GetCardNetworkTestCase{"6011000995500000", kDiscoverCard, true},
         GetCardNetworkTestCase{"6500000000000002", kDiscoverCard, true},
         GetCardNetworkTestCase{"3566002020360505", kJCBCard, true},
         GetCardNetworkTestCase{"3528000000000007", kJCBCard, true},
         GetCardNetworkTestCase{"5500005555555559", kMasterCard, true},
         GetCardNetworkTestCase{"5555555555555557", kMasterCard, true},
         GetCardNetworkTestCase{"5454545454545454", kMasterCard, true},
         GetCardNetworkTestCase{"5555515555555551", kMasterCard, true},
-        GetCardNetworkTestCase{"5405222222222226", kMasterCard, true},
         GetCardNetworkTestCase{"5478050000000007", kMasterCard, true},
         GetCardNetworkTestCase{"5111005111051128", kMasterCard, true},
         GetCardNetworkTestCase{"5112345112345114", kMasterCard, true},
         GetCardNetworkTestCase{"5115915115915118", kMasterCard, true},
         GetCardNetworkTestCase{"6247130048162403", kUnionPay, true},
         GetCardNetworkTestCase{"6247130048162403", kUnionPay, true},
         GetCardNetworkTestCase{"622384452162063648", kUnionPay, true},
         GetCardNetworkTestCase{"2204883716636153", kMirCard, true},
         GetCardNetworkTestCase{"2200111234567898", kMirCard, true},
         GetCardNetworkTestCase{"2200481349288130", kMirCard, true},
 
+        // The relevant sample numbers from
+        // https://www.bincodes.com/bank-creditcard-generator/ and
+        // https://www.ebanx.com/business/en/developers/integrations/testing/credit-card-test-numbers
+        GetCardNetworkTestCase{"5067001446391275", kEloCard, true},
+        GetCardNetworkTestCase{"6362970000457013", kEloCard, true},
+
         // Empty string
         GetCardNetworkTestCase{std::string(), kGenericCard, false},
 
         // Non-numeric
         GetCardNetworkTestCase{"garbage", kGenericCard, false},
         GetCardNetworkTestCase{"4garbage", kVisaCard, false},
 
         // Fails Luhn check.
         GetCardNetworkTestCase{"4111111111111112", kVisaCard, false},
         GetCardNetworkTestCase{"6247130048162413", kUnionPay, false},
@@ skipping 14 matching lines @@
     CreditCardTest,
     GetCardNetworkTestBatch2,
     testing::Values(
         // Invalid length.
         GetCardNetworkTestCase{"3434343434343434", kAmericanExpressCard, false},
         GetCardNetworkTestCase{"411111111111116", kVisaCard, false},
         GetCardNetworkTestCase{"220011123456783", kMirCard, false},
 
         // Issuer Identification Numbers (IINs) that Chrome recognizes.
         GetCardNetworkTestCase{"4", kVisaCard, false},
-        GetCardNetworkTestCase{"22", kMirCard, false},
+        GetCardNetworkTestCase{"2200", kMirCard, false},

[Mathieu, 2017/05/26 13:48:32]

can we have a mastercard that starts with 2

[jiahuiguo, 2017/05/26 19:44:10]

Done.

+        GetCardNetworkTestCase{"2201", kMirCard, false},
+        GetCardNetworkTestCase{"2202", kMirCard, false},
+        GetCardNetworkTestCase{"2203", kMirCard, false},
+        GetCardNetworkTestCase{"2204", kMirCard, false},
         GetCardNetworkTestCase{"34", kAmericanExpressCard, false},
         GetCardNetworkTestCase{"37", kAmericanExpressCard, false},
         GetCardNetworkTestCase{"300", kDinersCard, false},
         GetCardNetworkTestCase{"301", kDinersCard, false},
         GetCardNetworkTestCase{"302", kDinersCard, false},
         GetCardNetworkTestCase{"303", kDinersCard, false},
         GetCardNetworkTestCase{"304", kDinersCard, false},
         GetCardNetworkTestCase{"305", kDinersCard, false},
-        GetCardNetworkTestCase{"3095", kDinersCard, false},
+        GetCardNetworkTestCase{"309", kDinersCard, false},
         GetCardNetworkTestCase{"36", kDinersCard, false},
         GetCardNetworkTestCase{"38", kDinersCard, false},
         GetCardNetworkTestCase{"39", kDinersCard, false},
         GetCardNetworkTestCase{"6011", kDiscoverCard, false},
         GetCardNetworkTestCase{"644", kDiscoverCard, false},
         GetCardNetworkTestCase{"645", kDiscoverCard, false},
         GetCardNetworkTestCase{"646", kDiscoverCard, false},
         GetCardNetworkTestCase{"647", kDiscoverCard, false},
         GetCardNetworkTestCase{"648", kDiscoverCard, false},
         GetCardNetworkTestCase{"649", kDiscoverCard, false},
         GetCardNetworkTestCase{"65", kDiscoverCard, false},
+        GetCardNetworkTestCase{"5067", kEloCard, false},
+        GetCardNetworkTestCase{"5090", kEloCard, false},
+        GetCardNetworkTestCase{"636297", kEloCard, false},
         GetCardNetworkTestCase{"3528", kJCBCard, false},
         GetCardNetworkTestCase{"3531", kJCBCard, false},
         GetCardNetworkTestCase{"3589", kJCBCard, false},
         GetCardNetworkTestCase{"51", kMasterCard, false},
         GetCardNetworkTestCase{"52", kMasterCard, false},
         GetCardNetworkTestCase{"53", kMasterCard, false},
         GetCardNetworkTestCase{"54", kMasterCard, false},
         GetCardNetworkTestCase{"55", kMasterCard, false},
         GetCardNetworkTestCase{"62", kUnionPay, false},
 
         // Not enough data to determine an IIN uniquely.
         GetCardNetworkTestCase{"2", kGenericCard, false},
         GetCardNetworkTestCase{"3", kGenericCard, false},
         GetCardNetworkTestCase{"30", kGenericCard, false},
-        GetCardNetworkTestCase{"309", kGenericCard, false},
         GetCardNetworkTestCase{"35", kGenericCard, false},
         GetCardNetworkTestCase{"5", kGenericCard, false},
         GetCardNetworkTestCase{"6", kGenericCard, false},
         GetCardNetworkTestCase{"60", kGenericCard, false},
         GetCardNetworkTestCase{"601", kGenericCard, false},
         GetCardNetworkTestCase{"64", kGenericCard, false}));
 
 class GetCardNetworkTestBatch3
     : public testing::TestWithParam<GetCardNetworkTestCase> {};
 
 TEST_P(GetCardNetworkTestBatch3, GetCardNetwork) {
   auto test_case = GetParam();
   base::string16 card_number = ASCIIToUTF16(test_case.card_number);
   SCOPED_TRACE(card_number);
   EXPECT_EQ(test_case.issuer_network, CreditCard::GetCardNetwork(card_number));
   EXPECT_EQ(test_case.is_valid, IsValidCreditCardNumber(card_number));
 }
 
 INSTANTIATE_TEST_CASE_P(
     CreditCardTest,
     GetCardNetworkTestBatch3,
     testing::Values(
         // Unknown IINs.
         GetCardNetworkTestCase{"0", kGenericCard, false},
         GetCardNetworkTestCase{"1", kGenericCard, false},
         GetCardNetworkTestCase{"306", kGenericCard, false},
         GetCardNetworkTestCase{"307", kGenericCard, false},
         GetCardNetworkTestCase{"308", kGenericCard, false},
-        GetCardNetworkTestCase{"3091", kGenericCard, false},
-        GetCardNetworkTestCase{"3094", kGenericCard, false},
-        GetCardNetworkTestCase{"3096", kGenericCard, false},
         GetCardNetworkTestCase{"31", kGenericCard, false},
         GetCardNetworkTestCase{"32", kGenericCard, false},
         GetCardNetworkTestCase{"33", kGenericCard, false},
         GetCardNetworkTestCase{"351", kGenericCard, false},
         GetCardNetworkTestCase{"3527", kGenericCard, false},
         GetCardNetworkTestCase{"359", kGenericCard, false},
         GetCardNetworkTestCase{"50", kGenericCard, false},
         GetCardNetworkTestCase{"56", kGenericCard, false},
         GetCardNetworkTestCase{"57", kGenericCard, false},
         GetCardNetworkTestCase{"58", kGenericCard, false},
@@ skipping 247 matching lines @@
               credit_card0.GetLastUsedDateForDisplay(test_case.app_locale));
     EXPECT_EQ(test_case.last_used_date,
               credit_card1.GetLastUsedDateForDisplay(test_case.app_locale));
     EXPECT_EQ(test_case.last_used_year_ago,
               credit_card2.GetLastUsedDateForDisplay(test_case.app_locale));
     variation_params_.ClearAllVariationParams();
   }
 }
 
 }  // namespace autofill