Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2906713002: Revert "cros: close dialog when shill detects captive portal network switched to online" (Closed)

Created:
3 years, 7 months ago by Qiang(Joe) Xu
Modified:
3 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "cros: close dialog when shill detects captive portal network switched to online" This reverts commit 4179f08f0a422e3f78c822565cc067fee99987e9, reviewed on https://codereview.chromium.org/2823323002 This is a follow up revert of crrev.com/2910503002. BUG=718094 TEST=none Review-Url: https://codereview.chromium.org/2906713002 Cr-Commit-Position: refs/heads/master@{#474816} Committed: https://chromium.googlesource.com/chromium/src/+/5eaab0b12f3a1b8ad8e0fbf803ebcee97fdb58d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_notification_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_notification_controller.cc View 3 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Qiang(Joe) Xu
3 years, 7 months ago (2017-05-25 19:02:35 UTC) #3
stevenjb
lgtm
3 years, 7 months ago (2017-05-25 21:06:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906713002/1
3 years, 7 months ago (2017-05-25 21:08:43 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 21:48:29 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5eaab0b12f3a1b8ad8e0fbf803eb...

Powered by Google App Engine
This is Rietveld 408576698