Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Unified Diff: chrome/browser/chromeos/net/network_portal_notification_controller.h

Issue 2906713002: Revert "cros: close dialog when shill detects captive portal network switched to online" (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/net/network_portal_notification_controller.h
diff --git a/chrome/browser/chromeos/net/network_portal_notification_controller.h b/chrome/browser/chromeos/net/network_portal_notification_controller.h
index 4a3dfdbc2f72578daf9dd800565219f973c96f7e..635d104c96c037c60f7de23b98acebe379c72e44 100644
--- a/chrome/browser/chromeos/net/network_portal_notification_controller.h
+++ b/chrome/browser/chromeos/net/network_portal_notification_controller.h
@@ -125,9 +125,6 @@ class NetworkPortalNotificationController
const NetworkState* network,
const NetworkPortalDetector::CaptivePortalState& state) override;
- // Unique identifier of the default network.
- std::string default_network_id_;
-
// Last network guid for which notification was displayed.
std::string last_network_guid_;
@@ -137,6 +134,9 @@ class NetworkPortalNotificationController
// Currently displayed authorization dialog, or NULL if none.
NetworkPortalWebDialog* dialog_ = nullptr;
+ // Do not close Portal Login dialog on "No network" error in browser tests.
+ bool ignore_no_network_for_testing_ = false;
+
// This is called if the controller learns about a potential change of the
// captive portal.
base::Closure retry_detection_callback_;

Powered by Google App Engine
This is Rietveld 408576698