Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1338)

Unified Diff: chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

Issue 2906713002: Revert "cros: close dialog when shill detects captive portal network switched to online" (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/net/network_portal_notification_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc
diff --git a/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc b/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc
index c82a55c67cf7c9d26620c643a84e35d3b7fc0cfb..f9948accbe3dd75bdbe7dcdfbd3c4c9dc5f18cf7 100644
--- a/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc
+++ b/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc
@@ -153,6 +153,11 @@ class NetworkPortalDetectorImplBrowserTest
MessageCenter* message_center() { return MessageCenter::Get(); }
+ void SetIgnoreNoNetworkForTesting() {
+ network_portal_detector_->notification_controller_
+ ->SetIgnoreNoNetworkForTesting();
+ }
+
const NetworkPortalWebDialog* GetDialog() const {
return network_portal_detector_->notification_controller_
->GetDialogForTesting();
@@ -248,6 +253,8 @@ void NetworkPortalDetectorImplBrowserTestIgnoreProxy::TestImpl(
LoginUser(kTestUser);
content::RunAllPendingInMessageLoop();
+ SetIgnoreNoNetworkForTesting();
+
ProfileManager::GetActiveUserProfile()->GetPrefs()->SetBoolean(
prefs::kCaptivePortalAuthenticationIgnoresProxy, preference_value);
« no previous file with comments | « no previous file | chrome/browser/chromeos/net/network_portal_notification_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698