Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2906493003: Get rid of FrameSelection::SetSelectedRange() (Closed)

Created:
3 years, 7 months ago by tanvir
Modified:
3 years, 7 months ago
Reviewers:
Srirama, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of FrameSelection::SetSelectedRange() This CL removed FrameSelection::SetSelectedRange(). We use FrameSelection::SetSelection() now instead of SetSelectedRange(). This is done to avoid redundant code checks. BUG=721190 Review-Url: https://codereview.chromium.org/2906493003 Cr-Commit-Position: refs/heads/master@{#474613} Committed: https://chromium.googlesource.com/chromium/src/+/dfe8a2dd435c4eed9b079ea408794da551497fc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -33 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp View 4 chunks +18 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
tanvir
PTAL! Thanks
3 years, 7 months ago (2017-05-25 07:30:44 UTC) #4
yosin_UTC9
lgtm
3 years, 7 months ago (2017-05-25 08:37:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906493003/1
3 years, 7 months ago (2017-05-25 08:37:25 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 09:22:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dfe8a2dd435c4eed9b079ea40879...

Powered by Google App Engine
This is Rietveld 408576698