Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2906493003: Get rid of FrameSelection::SetSelectedRange() (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 115
116 void SetSelection(const SelectionInDOMTree&, 116 void SetSelection(const SelectionInDOMTree&,
117 SetSelectionOptions = kCloseTyping | kClearTypingStyle, 117 SetSelectionOptions = kCloseTyping | kClearTypingStyle,
118 CursorAlignOnScroll = CursorAlignOnScroll::kIfNeeded, 118 CursorAlignOnScroll = CursorAlignOnScroll::kIfNeeded,
119 TextGranularity = kCharacterGranularity); 119 TextGranularity = kCharacterGranularity);
120 120
121 void SetSelection(const SelectionInFlatTree&, 121 void SetSelection(const SelectionInFlatTree&,
122 SetSelectionOptions = kCloseTyping | kClearTypingStyle, 122 SetSelectionOptions = kCloseTyping | kClearTypingStyle,
123 CursorAlignOnScroll = CursorAlignOnScroll::kIfNeeded, 123 CursorAlignOnScroll = CursorAlignOnScroll::kIfNeeded,
124 TextGranularity = kCharacterGranularity); 124 TextGranularity = kCharacterGranularity);
125 bool SetSelectedRange(
126 const EphemeralRange&,
127 TextAffinity,
128 SelectionDirectionalMode = SelectionDirectionalMode::kNonDirectional,
129 FrameSelection::SetSelectionOptions = kCloseTyping | kClearTypingStyle);
130 void SelectAll(EUserTriggered = kNotUserTriggered); 125 void SelectAll(EUserTriggered = kNotUserTriggered);
131 void Clear(); 126 void Clear();
132 bool IsHidden() const; 127 bool IsHidden() const;
133 128
134 // TODO(tkent): These two functions were added to fix crbug.com/695211 without 129 // TODO(tkent): These two functions were added to fix crbug.com/695211 without
135 // changing focus behavior. Once we fix crbug.com/690272, we can remove these 130 // changing focus behavior. Once we fix crbug.com/690272, we can remove these
136 // functions. 131 // functions.
137 // setSelectionDeprecated() returns true if didSetSelectionDeprecated() should 132 // setSelectionDeprecated() returns true if didSetSelectionDeprecated() should
138 // be called. 133 // be called.
139 bool SetSelectionDeprecated(const SelectionInDOMTree&, 134 bool SetSelectionDeprecated(const SelectionInDOMTree&,
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 307
313 } // namespace blink 308 } // namespace blink
314 309
315 #ifndef NDEBUG 310 #ifndef NDEBUG
316 // Outside the WebCore namespace for ease of invocation from gdb. 311 // Outside the WebCore namespace for ease of invocation from gdb.
317 void showTree(const blink::FrameSelection&); 312 void showTree(const blink::FrameSelection&);
318 void showTree(const blink::FrameSelection*); 313 void showTree(const blink::FrameSelection*);
319 #endif 314 #endif
320 315
321 #endif // FrameSelection_h 316 #endif // FrameSelection_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698