Get rid of FrameSelection::SetSelectedRange()

third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/FrameSelection.h"
 
 #include <memory>
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
@@ skipping 42 matching lines @@
 Text* FrameSelectionTest::AppendTextNode(const String& data) {
   Text* text = GetDocument().createTextNode(data);
   GetDocument().body()->AppendChild(text);
   return text;
 }
 
 TEST_F(FrameSelectionTest, FirstEphemeralRangeOf) {
   SetBodyContent("<div id=sample>0123456789</div>abc");
   Element* const sample = GetDocument().getElementById("sample");
   Node* const text = sample->firstChild();
-  Selection().SetSelectedRange(
-      EphemeralRange(Position(text, 3), Position(text, 6)), VP_DEFAULT_AFFINITY,
-      SelectionDirectionalMode::kNonDirectional, 0);
+  Selection().SetSelection(SelectionInDOMTree::Builder()
+                               .SetBaseAndExtent(EphemeralRange(
+                                   Position(text, 3), Position(text, 6)))
+                               .Build(),
+                           0);
   sample->setAttribute(HTMLNames::styleAttr, "display:none");
   // Move |VisibleSelection| before "abc".
   UpdateAllLifecyclePhases();
   const EphemeralRange& range =
       FirstEphemeralRangeOf(Selection().ComputeVisibleSelectionInDOMTree());
   EXPECT_EQ(Position(sample->nextSibling(), 0), range.StartPosition())
       << "firstRagne() should return current selection value";
   EXPECT_EQ(Position(sample->nextSibling(), 0), range.EndPosition());
 }
 
@@ skipping 213 matching lines @@
                                .SetIsHandleVisible(true)
                                .Build());
   EXPECT_TRUE(Selection().IsHandleVisible());
   Selection().SelectAll();
   EXPECT_TRUE(Selection().IsHandleVisible())
       << "If handles were present before"
          "selectAll. Then they should be present"
          "after it.";
 }
 
-TEST_F(FrameSelectionTest, SetSelectedRangeHidesHandle) {
+TEST_F(FrameSelectionTest, SelectionOnRangeHidesHandles) {
   Text* text = AppendTextNode("Hello, World!");
   GetDocument().View()->UpdateAllLifecyclePhases();
   Selection().SetSelection(
       SelectionInDOMTree::Builder()
           .SetBaseAndExtent(Position(text, 0), Position(text, 5))
           .SetIsHandleVisible(false)
           .Build());
 
-  Selection().SetSelectedRange(
-      EphemeralRange(Position(text, 0), Position(text, 12)),
-      VP_DEFAULT_AFFINITY, SelectionDirectionalMode::kNonDirectional, 0);
+  Selection().SetSelection(SelectionInDOMTree::Builder()
+                               .SetBaseAndExtent(EphemeralRange(
+                                   Position(text, 0), Position(text, 12)))
+                               .Build(),
+                           0);
 
   EXPECT_FALSE(Selection().IsHandleVisible())
-      << "After SetSelectedRange handles shouldn't be present.";
+      << "After SetSelection on Range, handles shouldn't be present.";
 
   Selection().SetSelection(
       SelectionInDOMTree::Builder()
           .SetBaseAndExtent(Position(text, 0), Position(text, 5))
           .SetIsHandleVisible(true)
           .Build());
 
-  Selection().SetSelectedRange(
-      EphemeralRange(Position(text, 0), Position(text, 12)),
-      VP_DEFAULT_AFFINITY, SelectionDirectionalMode::kNonDirectional, 0);
+  Selection().SetSelection(SelectionInDOMTree::Builder()
+                               .SetBaseAndExtent(EphemeralRange(
+                                   Position(text, 0), Position(text, 12)))
+                               .Build(),
+                           0);
 
   EXPECT_FALSE(Selection().IsHandleVisible())
-      << "After SetSelectedRange handles shouldn't be present.";
+      << "After SetSelection on Range, handles shouldn't be present.";
 }
 
 // Regression test for crbug.com/702756
 // Test case excerpted from editing/undo/redo_correct_selection.html
 TEST_F(FrameSelectionTest, SelectInvalidPositionInFlatTreeDoesntCrash) {
   SetBodyContent("foo<option><select></select></option>");
   Element* body = GetDocument().body();
   Element* select = GetDocument().QuerySelector("select");
   Node* foo = body->firstChild();
   Selection().SetSelection(SelectionInDOMTree::Builder()
@@ skipping 585 matching lines @@
   EXPECT_FALSE(Selection().IsHidden());
 
   Element* const alink = GetDocument().getElementById("alink");
   alink->focus();
   EXPECT_TRUE(Selection().GetSelectionInDOMTree().IsRange());
   EXPECT_FALSE(Selection().SelectionHasFocus());
   EXPECT_FALSE(Selection().IsHidden());  // Range still visible.
 }
 
 }  // namespace blink