Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2906423002: [vr] Migrate from vr::Colorf to SkColor (Closed)

Created:
3 years, 6 months ago by cjgrant
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[vr] Migrate from vr::Colorf to SkColor BUG=726363 Review-Url: https://codereview.chromium.org/2911663002 Cr-Original-Commit-Position: refs/heads/master@{#475129} Review-Url: https://codereview.chromium.org/2906423002 . Cr-Commit-Position: refs/branch-heads/3112@{#16} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/bac6a3711cbbd2423979856073f66a8ddce24f6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -77 lines) Patch
M chrome/browser/android/vr_shell/color_scheme.h View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/android/vr_shell/color_scheme.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/screen_dimmer.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/screen_dimmer.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/ui_element.h View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc View 4 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_renderer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_renderer.cc View 5 chunks +13 lines, -12 lines 0 comments Download
M device/vr/vr_types.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
cjgrant
3 years, 6 months ago (2017-05-29 18:51:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bac6a3711cbbd2423979856073f66a8ddce24f6b.

Powered by Google App Engine
This is Rietveld 408576698