[vr] Migrate from vr::Colorf to SkColor

[vr] Migrate from vr::Colorf to SkColor

BUG=726363
Review-Url: https://codereview.chromium.org/2911663002
Cr-Commit-Position: refs/heads/master@{#475129}
Committed: https://chromium.googlesource.com/chromium/src/+/60a9afebd0702a5e3097e928b6c89a5271ca91ee

[Ian Vollick, 2017-05-26 12:58:50]

Description was changed from

==========
[vr] Migrate from vr::Colorf to SkColor

BUG=726363
==========

to

==========
[vr] Migrate from vr::Colorf to SkColor

BUG=726363
==========

[Ian Vollick, 2017-05-26 12:58:50]

vollick@chromium.org changed reviewers:
+ cjgrant@chromium.org

[Ian Vollick, 2017-05-26 12:59:33]

vollick@chromium.org changed reviewers:
+ bajones@chromium.org

[cjgrant, 2017-05-26 13:57:05]

lgtm

https://codereview.chromium.org/2911663002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/ui_elements/ui_element.h (right):

https://codereview.chromium.org/2911663002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_elements/ui_element.h:301: SkColor
edge_color_ = 0xFFFFFFFF;
Should we be using SkColor_WHITE here, or do you want the consistent hex format?

[Ian Vollick, 2017-05-26 14:24:40]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[Ian Vollick, 2017-05-26 14:24:46]

https://codereview.chromium.org/2911663002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/ui_elements/ui_element.h (right):

https://codereview.chromium.org/2911663002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_elements/ui_element.h:301: SkColor
edge_color_ = 0xFFFFFFFF;
On 2017/05/26 13:57:05, cjgrant wrote:
> Should we be using SkColor_WHITE here, or do you want the consistent hex
format?

SK_ColorWHITE is way better - it just didn't occur to me. Updated.

[commit-bot: I haz the power, 2017-05-26 14:24:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 15:08:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 15:08:58]

Dry run: This issue passed the CQ dry run.

[bajones, 2017-05-26 20:25:46]

LGTM

[Ian Vollick, 2017-05-26 20:26:34]

The CQ bit was checked by vollick@chromium.org

[Ian Vollick, 2017-05-26 20:26:36]

The patchset sent to the CQ was uploaded after l-g-t-m from cjgrant@chromium.org
Link to the patchset: https://codereview.chromium.org/2911663002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-05-26 20:26:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 21:15:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495830394339050,
"parent_rev": "98a3e4a19ea5cbfe16f3486b14e458df441c394f", "commit_rev":
"60a9afebd0702a5e3097e928b6c89a5271ca91ee"}

[commit-bot: I haz the power, 2017-05-26 21:16:05]

Description was changed from

==========
[vr] Migrate from vr::Colorf to SkColor

BUG=726363
==========

to

==========
[vr] Migrate from vr::Colorf to SkColor

BUG=726363

Review-Url: https://codereview.chromium.org/2911663002
Cr-Commit-Position: refs/heads/master@{#475129}
Committed:
https://chromium.googlesource.com/chromium/src/+/60a9afebd0702a5e3097e928b6c8...
==========

[commit-bot: I haz the power, 2017-05-26 21:16:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/60a9afebd0702a5e3097e928b6c8...