Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2905793002: Replace pointers in ComputedStyle::*DataEquivalent functions with refs. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 6 months ago
Reviewers:
meade_UTC10
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace pointers in ComputedStyle::*DataEquivalent functions with refs. Currently, there are a few *DataEquivalent functions in ComputedStyle that take a pointer. All these functions assume that the pointers are not null, so we can simply replace them with references. BUG=628043 Review-Url: https://codereview.chromium.org/2905793002 Cr-Commit-Position: refs/heads/master@{#474924} Committed: https://chromium.googlesource.com/chromium/src/+/ea2ef980b38e4a7f741f9f8220f48841ddd71df7

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 3 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
shend
Hi Eddy, PTAL
3 years, 6 months ago (2017-05-25 22:25:34 UTC) #8
meade_UTC10
lgtm lol const_cast... nice
3 years, 6 months ago (2017-05-26 05:11:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905793002/20001
3 years, 6 months ago (2017-05-26 05:26:35 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 05:31:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ea2ef980b38e4a7f741f9f8220f4...

Powered by Google App Engine
This is Rietveld 408576698