third_party/WebKit/Source/core/style/ComputedStyle.cpp - Issue 2905793002: Replace pointers in ComputedStyle::*DataEquivalent functions with refs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2905793002: Replace pointers in ComputedStyle::*DataEquivalent functions with refs. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

index 4d7efa94d904859440e5315eff086c09ad17e6d0..31179c9743957a846bcfecb507ca08bcf6e5d8a6 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

@@ -185,7 +185,7 @@ StyleRecalcChange ComputedStyle::StylePropagationDiff(

if (old_style->Display() != new_style->Display() ||

old_style->HasPseudoStyle(kPseudoIdFirstLetter) !=

new_style->HasPseudoStyle(kPseudoIdFirstLetter) ||

- !old_style->ContentDataEquivalent(new_style) ||

+ !old_style->ContentDataEquivalent(*new_style) ||

old_style->HasTextCombine() != new_style->HasTextCombine())

return kReattach;

« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | no next file » | no next file with comments »