Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2907713002: Move RareNonInheritedData::*DataEquivalent to ComputedStyle. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move RareNonInheritedData::*DataEquivalent to ComputedStyle. When we generate RareNonInheritedData, we would no longer generate helper methods like ReflectionDataEquivalent. These need to be handwritten in ComputedStyle. This patch moves these helper methods from RareNonInheritedData to ComputedStyle. This is preparation for generating RareNonInheritedData. BUG=628043 Review-Url: https://codereview.chromium.org/2907713002 Cr-Commit-Position: refs/heads/master@{#474958} Committed: https://chromium.googlesource.com/chromium/src/+/99af26c7d6c7f9d7843ab1f55b265556aabd6497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -70 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 6 chunks +12 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 2 chunks +4 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp View 2 chunks +11 lines, -47 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
shend
Hi Eddy, PTAL
3 years, 7 months ago (2017-05-25 22:58:52 UTC) #4
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-26 05:14:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907713002/1
3 years, 7 months ago (2017-05-26 06:09:42 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 07:50:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/99af26c7d6c7f9d7843ab1f55b26...

Powered by Google App Engine
This is Rietveld 408576698