Chromium Code Reviews Chromium Code Reviews
Issue
2905713002:
Reland of media: Add experimental feature to enable Mojo CDM on desktop Chromium (Closed)
DescriptionReland of media: Add experimental feature to enable Mojo CDM on desktop Chromium (patchset #1 id:1 of https://codereview.chromium.org/2902943002/ )
Reason for revert:
The fix on gn visibility has been landed in https://codereview.chromium.org/2901943003/
Original issue's description:
> Revert of media: Add experimental feature to enable Mojo CDM on desktop Chromium (patchset #5 id:180001 of https://codereview.chromium.org/2900773004/ )
>
> Reason for revert:
> This CL seems to break |generate_build_files| step on chromium.chrome/Google Chrome Win. Please see crbug.com/725808 for details.
>
> Original issue's description:
> > media: Add experimental feature to enable Mojo CDM on desktop Chromium
> >
> > Currently in Chromium, the CDM is hosted by the CDM adapter which is a
> > pepper plugin. This CL updates the build flags such that when pepper
> > CDMs are enabled, we also enable hosting the CDM using mojo in an
> > unsandboxed utility process. By default, pepper CDM will always be
> > used and mojo CDM is disabled. A new base::Feature is added such that
> > developers and testers can enable mojo CDM for early prototyping and
> > testing.
> >
> > To enable mojo CDM, please add the following command line options:
> >
> > --enable-features=MojoCdm
> >
> > Detailed changes in this CL:
> > - Updated build flags to enable mojo CDM in utility process when pepper
> > CDMs are enabled.
> > - Add a base::Feature media::kMojoCdm to enable mojo CDM at run time.
> > - Add CdmAdapterFactory to create CdmAdapter, which hosts the CDM
> > binary.
> > - Register MediaService in the utility process to create
> > CdmAdapterFactory when requested.
> > - Also copy base::Feature flags on command line for utility process.
> >
> > Note that Mojo CDM on desktop Chromium is still under development. Some
> > features will not work. Also, the CDM is running in an unsandboxed
> > utility process since we cannot load the CDM in a sandboxed utility
> > process yet. These will be addressed in future CLs.
> >
> > BUG=403462, 725394, 561090
> >
> > Review-Url: https://codereview.chromium.org/2900773004
> > Cr-Commit-Position: refs/heads/master@{#474186}
> > Committed: https://chromium.googlesource.com/chromium/src/+/846b429c5175d3637e4183bc06eb417eee09482c
>
> TBR=jrummell@chromium.org,jam@chromium.org,xhwang@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=403462, 725394, 561090, 725808
>
> Review-Url: https://codereview.chromium.org/2902943002
> Cr-Commit-Position: refs/heads/master@{#474202}
> Committed: https://chromium.googlesource.com/chromium/src/+/94274172ed5f2f5f5b2ead35f07e5e011a73e3b4
TBR=jrummell@chromium.org,jam@chromium.org,vitaliii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=403462, 725394, 561090, 725808
Review-Url: https://codereview.chromium.org/2905713002
Cr-Commit-Position: refs/heads/master@{#474376}
Committed: https://chromium.googlesource.com/chromium/src/+/79fc0eff0e3bf95ad6a9759a49d9c837781440f8
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
