media: Fix //media/mojo/clients visibility

media: Fix //media/mojo/clients visibility

Currently //content/renderer:renderer is in //media/mojo/clients'
visibility list. However when using split_static_library, we could end
up having //content/renderer:renderer_0 target which has all the same
dependencies as //content/renderer:renderer. However,
//content/renderer:renderer_0 isn't in //media/mojo/clients' visibility
list, causing gn check failures.

This is not the first time split_static_library causing similar issues.
For example, see issue 645621.

I'll send an email discussing this generic issue. Meanwhile, this CL
relaxes the visibility rule such that all //content/renderer:* targets
are in //media/mojo/clients' visibility list. This is also how issue
645621 was "fixed".

Here's the current gn check log:

------------------------------------------
C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //build/split_static_library.gni:27:7: Dependency not allowed.
      static_library(current_name) {
      ^-----------------------------
The item //content/renderer:renderer_0
can not depend on //media/mojo/clients:clients
because it is not in //media/mojo/clients:clients's visibility list: [
  //content/renderer:renderer
  ...
]
------------------------------------------

BUG=725808
Review-Url: https://codereview.chromium.org/2901943003
Cr-Commit-Position: refs/heads/master@{#474375}
Committed: https://chromium.googlesource.com/chromium/src/+/c1878a272a87bd797949717bebdfdbc1e6f0c143

[xhwang, 2017-05-24 16:55:33]

Description was changed from

==========
media: Fix //media/mojo/clients visibility

Currently //content/renderer:renderer is in //media/mojo/clients'
visibility list. Howevern when using split_static_library, we could end
up having //content/renderer:renderer_0 target which has all the same
dependencies as //content/renderer:renderer. However,
//content/renderer:renderer_0 isn't in //media/mojo/clients' visilibity
list, causing gn check failures.

This is not the first time split_static_library causing similar issues.
For example, issue 645621.

I'll send an email discussing this generic issue. Meanwhile, this CL
relaxes the visibility rule such that all //content/renderer:* targets
are in //media/mojo/clients' visilibity list.

Here's the current gn check log:

------------------------------------------
C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //build/split_static_library.gni:27:7: Dependency not allowed.
      static_library(current_name) {
      ^-----------------------------
The item //content/renderer:renderer_0
can not depend on //media/mojo/clients:clients
because it is not in //media/mojo/clients:clients's visibility list: [
  //chromecast/*
  //content/renderer:renderer
  //media/mojo:*
  //media/mojo/services:*
  //media/test/*
  //content/gpu:*
  //content/test/*
]
------------------------------------------

BUG=725808
==========

to

==========
media: Fix //media/mojo/clients visibility

Currently //content/renderer:renderer is in //media/mojo/clients'
visibility list. However when using split_static_library, we could end
up having //content/renderer:renderer_0 target which has all the same
dependencies as //content/renderer:renderer. However,
//content/renderer:renderer_0 isn't in //media/mojo/clients' visibility
list, causing gn check failures.

This is not the first time split_static_library causing similar issues.
For example, see issue 645621.

I'll send an email discussing this generic issue. Meanwhile, this CL
relaxes the visibility rule such that all //content/renderer:* targets
are in //media/mojo/clients' visibility list. This is also how issue
645621 was "fixed".

Here's the current gn check log:

------------------------------------------
C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //build/split_static_library.gni:27:7: Dependency not allowed.
      static_library(current_name) {
      ^-----------------------------
The item //content/renderer:renderer_0
can not depend on //media/mojo/clients:clients
because it is not in //media/mojo/clients:clients's visibility list: [
  //content/renderer:renderer
  ...
]
------------------------------------------

BUG=725808
==========

[xhwang, 2017-05-24 16:55:33]

xhwang@chromium.org changed reviewers:
+ brettw@chromium.org, jrummell@chromium.org

[xhwang, 2017-05-24 16:56:03]

jrummell: PTAL
brettw: FYI

[xhwang, 2017-05-24 16:56:13]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 16:56:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jrummell, 2017-05-24 18:22:35]

lgtm

[xhwang, 2017-05-24 18:26:43]

The CQ bit was unchecked by xhwang@chromium.org

[xhwang, 2017-05-24 18:26:44]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2017-05-24 18:27:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 18:48:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495650404437190, "parent_rev":
"1e498ef57c4bca46019a872695dcbba2fbef82e4", "commit_rev":
"c1878a272a87bd797949717bebdfdbc1e6f0c143"}

[commit-bot: I haz the power, 2017-05-24 18:49:02]

Description was changed from

==========
media: Fix //media/mojo/clients visibility

Currently //content/renderer:renderer is in //media/mojo/clients'
visibility list. However when using split_static_library, we could end
up having //content/renderer:renderer_0 target which has all the same
dependencies as //content/renderer:renderer. However,
//content/renderer:renderer_0 isn't in //media/mojo/clients' visibility
list, causing gn check failures.

This is not the first time split_static_library causing similar issues.
For example, see issue 645621.

I'll send an email discussing this generic issue. Meanwhile, this CL
relaxes the visibility rule such that all //content/renderer:* targets
are in //media/mojo/clients' visibility list. This is also how issue
645621 was "fixed".

Here's the current gn check log:

------------------------------------------
C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //build/split_static_library.gni:27:7: Dependency not allowed.
      static_library(current_name) {
      ^-----------------------------
The item //content/renderer:renderer_0
can not depend on //media/mojo/clients:clients
because it is not in //media/mojo/clients:clients's visibility list: [
  //content/renderer:renderer
  ...
]
------------------------------------------

BUG=725808
==========

to

==========
media: Fix //media/mojo/clients visibility

Currently //content/renderer:renderer is in //media/mojo/clients'
visibility list. However when using split_static_library, we could end
up having //content/renderer:renderer_0 target which has all the same
dependencies as //content/renderer:renderer. However,
//content/renderer:renderer_0 isn't in //media/mojo/clients' visibility
list, causing gn check failures.

This is not the first time split_static_library causing similar issues.
For example, see issue 645621.

I'll send an email discussing this generic issue. Meanwhile, this CL
relaxes the visibility rule such that all //content/renderer:* targets
are in //media/mojo/clients' visibility list. This is also how issue
645621 was "fixed".

Here's the current gn check log:

------------------------------------------
C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //build/split_static_library.gni:27:7: Dependency not allowed.
      static_library(current_name) {
      ^-----------------------------
The item //content/renderer:renderer_0
can not depend on //media/mojo/clients:clients
because it is not in //media/mojo/clients:clients's visibility list: [
  //content/renderer:renderer
  ...
]
------------------------------------------

BUG=725808

Review-Url: https://codereview.chromium.org/2901943003
Cr-Commit-Position: refs/heads/master@{#474375}
Committed:
https://chromium.googlesource.com/chromium/src/+/c1878a272a87bd797949717bebdf...
==========

[commit-bot: I haz the power, 2017-05-24 18:49:03]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c1878a272a87bd797949717bebdf...