Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2902943002: Revert of media: Add experimental feature to enable Mojo CDM on desktop Chromium (Closed)

Created:
3 years, 7 months ago by vitaliii
Modified:
3 years, 7 months ago
Reviewers:
jrummell, jam, xhwang
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, eme-reviews_chromium.org, nasko+codewatch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, ddorwin, Ken Rockot(use gerrit already)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of media: Add experimental feature to enable Mojo CDM on desktop Chromium (patchset #5 id:180001 of https://codereview.chromium.org/2900773004/ ) Reason for revert: This CL seems to break |generate_build_files| step on chromium.chrome/Google Chrome Win. Please see crbug.com/725808 for details. Original issue's description: > media: Add experimental feature to enable Mojo CDM on desktop Chromium > > Currently in Chromium, the CDM is hosted by the CDM adapter which is a > pepper plugin. This CL updates the build flags such that when pepper > CDMs are enabled, we also enable hosting the CDM using mojo in an > unsandboxed utility process. By default, pepper CDM will always be > used and mojo CDM is disabled. A new base::Feature is added such that > developers and testers can enable mojo CDM for early prototyping and > testing. > > To enable mojo CDM, please add the following command line options: > > --enable-features=MojoCdm > > Detailed changes in this CL: > - Updated build flags to enable mojo CDM in utility process when pepper > CDMs are enabled. > - Add a base::Feature media::kMojoCdm to enable mojo CDM at run time. > - Add CdmAdapterFactory to create CdmAdapter, which hosts the CDM > binary. > - Register MediaService in the utility process to create > CdmAdapterFactory when requested. > - Also copy base::Feature flags on command line for utility process. > > Note that Mojo CDM on desktop Chromium is still under development. Some > features will not work. Also, the CDM is running in an unsandboxed > utility process since we cannot load the CDM in a sandboxed utility > process yet. These will be addressed in future CLs. > > BUG=403462, 725394, 561090 > > Review-Url: https://codereview.chromium.org/2900773004 > Cr-Commit-Position: refs/heads/master@{#474186} > Committed: https://chromium.googlesource.com/chromium/src/+/846b429c5175d3637e4183bc06eb417eee09482c TBR=jrummell@chromium.org,jam@chromium.org,xhwang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=403462, 725394, 561090, 725808 Review-Url: https://codereview.chromium.org/2902943002 Cr-Commit-Position: refs/heads/master@{#474202} Committed: https://chromium.googlesource.com/chromium/src/+/94274172ed5f2f5f5b2ead35f07e5e011a73e3b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -239 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/media/encrypted_media_browsertest.cc View 4 chunks +8 lines, -11 lines 0 comments Download
M content/browser/service_manager/service_manager_context.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +8 lines, -12 lines 0 comments Download
M content/utility/BUILD.gn View 3 chunks +4 lines, -11 lines 0 comments Download
M content/utility/utility_service_factory.cc View 4 chunks +5 lines, -37 lines 0 comments Download
M media/BUILD.gn View 1 chunk +0 lines, -15 lines 0 comments Download
M media/base/media_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/media_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
D media/cdm/cdm_adapter_factory.h View 1 chunk +0 lines, -39 lines 0 comments Download
D media/cdm/cdm_adapter_factory.cc View 1 chunk +0 lines, -88 lines 0 comments Download
M media/cdm/cdm_allocator.h View 2 chunks +0 lines, -4 lines 0 comments Download
M media/media_options.gni View 3 chunks +4 lines, -7 lines 0 comments Download
M media/mojo/services/main.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
vitaliii
Created Revert of media: Add experimental feature to enable Mojo CDM on desktop Chromium
3 years, 7 months ago (2017-05-24 07:53:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902943002/1
3 years, 7 months ago (2017-05-24 07:54:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/94274172ed5f2f5f5b2ead35f07e5e011a73e3b4
3 years, 7 months ago (2017-05-24 07:55:22 UTC) #7
xhwang
3 years, 7 months ago (2017-05-24 18:51:07 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2905713002/ by xhwang@chromium.org.

The reason for reverting is: The fix on gn visibility has been landed in
https://codereview.chromium.org/2901943003/.

Powered by Google App Engine
This is Rietveld 408576698