Reduce absolute paths in generated ninja files

Reduce absolute paths in generated ninja files

After this change, the number of steps required for rebuilding all
after snapshot and "gn gen" is reduced to 711 (Linux Release build).

BUG=723856
Review-Url: https://codereview.chromium.org/2905523002
Cr-Commit-Position: refs/heads/master@{#475458}
Committed: https://chromium.googlesource.com/chromium/src/+/5e1f7259d0638f865ed7f5a6c1ecabf5b9968e2c

[wychen, 2017-05-24 00:27:11]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 00:28:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wychen, 2017-05-24 01:02:46]

Patchset #2 (id:20001) has been deleted

[wychen, 2017-05-24 01:02:52]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 01:04:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 04:03:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 04:03:57]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[wychen, 2017-05-24 04:42:09]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 04:42:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 06:28:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 06:28:26]

Dry run: This issue passed the CQ dry run.

[wychen, 2017-05-24 06:56:01]

wychen@chromium.org changed reviewers:
+ brettw@chromium.org

[wychen, 2017-05-24 06:56:02]

PTAL

[brettw, 2017-05-30 03:57:57]

LGTM if you revert build/config/gcc/BUILD.gn

If you think the changes there are correct, please follow up again.

https://codereview.chromium.org/2905523002/diff/60001/build/config/gcc/BUILD.gn
File build/config/gcc/BUILD.gn (right):

https://codereview.chromium.org/2905523002/diff/60001/build/config/gcc/BUILD....
build/config/gcc/BUILD.gn:89: "-Wl,-rpath-link=" + rebase_path(rpath_link,
root_build_dir),
I don't understand this one, it looks like the input should already be relative
to the build dir. When does this one have an effect?

https://codereview.chromium.org/2905523002/diff/60001/build/config/gcc/BUILD....
build/config/gcc/BUILD.gn:137: "-Wl,-rpath-link=" + rebase_path(_rpath_link,
root_build_dir),
Ditto here.

[wychen, 2017-05-30 06:34:05]

https://codereview.chromium.org/2905523002/diff/60001/build/config/gcc/BUILD.gn
File build/config/gcc/BUILD.gn (right):

https://codereview.chromium.org/2905523002/diff/60001/build/config/gcc/BUILD....
build/config/gcc/BUILD.gn:89: "-Wl,-rpath-link=" + rebase_path(rpath_link,
root_build_dir),
On 2017/05/30 03:57:56, brettw wrote:
> I don't understand this one, it looks like the input should already be
relative
> to the build dir. When does this one have an effect?

You are right. They don't have an effect.
Reverted.

Thanks for your eagle eye!

[wychen, 2017-05-30 06:35:38]

Description was changed from

==========
Reduce absolute paths in generated ninja files

BUG=723856
==========

to

==========
Reduce absolute paths in generated ninja files

After this change, the number of steps required for rebuilding all after
snapshot
and "gn gen" is reduced to 711 (Linux Release build).

BUG=723856
==========

[wychen, 2017-05-30 06:35:57]

Description was changed from

==========
Reduce absolute paths in generated ninja files

After this change, the number of steps required for rebuilding all after
snapshot
and "gn gen" is reduced to 711 (Linux Release build).

BUG=723856
==========

to

==========
Reduce absolute paths in generated ninja files

After this change, the number of steps required for rebuilding all
after snapshot and "gn gen" is reduced to 711 (Linux Release build).

BUG=723856
==========

[wychen, 2017-05-30 06:36:28]

The CQ bit was checked by wychen@chromium.org

[wychen, 2017-05-30 06:36:29]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2905523002/#ps80001
(title: "revert build/config/gcc/BUILD.gn, rebase")

[commit-bot: I haz the power, 2017-05-30 06:37:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 08:05:12]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496126188726810,
"parent_rev": "67618346e22720b39a26ff20d7b94f9b10cd5f22", "commit_rev":
"5e1f7259d0638f865ed7f5a6c1ecabf5b9968e2c"}

[commit-bot: I haz the power, 2017-05-30 08:05:27]

Description was changed from

==========
Reduce absolute paths in generated ninja files

After this change, the number of steps required for rebuilding all
after snapshot and "gn gen" is reduced to 711 (Linux Release build).

BUG=723856
==========

to

==========
Reduce absolute paths in generated ninja files

After this change, the number of steps required for rebuilding all
after snapshot and "gn gen" is reduced to 711 (Linux Release build).

BUG=723856

Review-Url: https://codereview.chromium.org/2905523002
Cr-Commit-Position: refs/heads/master@{#475458}
Committed:
https://chromium.googlesource.com/chromium/src/+/5e1f7259d0638f865ed7f5a6c1ec...
==========

[commit-bot: I haz the power, 2017-05-30 08:05:29]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/5e1f7259d0638f865ed7f5a6c1ec...