Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2909253002: Eliminate absolute paths in ninja files for Linux Release build (Closed)

Created:
3 years, 6 months ago by wychen
Modified:
3 years, 6 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, hiroshige+script_chromium.org, kochi+script_chromium.org, kouhei+script_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate absolute paths in ninja files for Linux Release build After this change, the number of steps required for rebuilding all in Linux Release build after snapshot and "gn gen" is reduced to 384, the same as touching OUT_DIR/build.ninja. BUG=723856 Review-Url: https://codereview.chromium.org/2909253002 Cr-Commit-Position: refs/heads/master@{#477584} Committed: https://chromium.googlesource.com/chromium/src/+/6bf8ffab8059f83d6fd93485184627fbe3fce2e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/google_input_tools/closure.gni View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
wychen
3 years, 6 months ago (2017-05-30 07:05:47 UTC) #3
wychen
PTAL
3 years, 6 months ago (2017-05-30 07:07:09 UTC) #5
aelias_OOO_until_Jul13
lgtm
3 years, 6 months ago (2017-05-30 18:32:11 UTC) #6
Shu Chen
lgtm
3 years, 6 months ago (2017-06-06 00:43:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909253002/1
3 years, 6 months ago (2017-06-07 06:20:52 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 08:52:13 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6bf8ffab8059f83d6fd934851846...

Powered by Google App Engine
This is Rietveld 408576698