Reduce absolute paths in generated ninja files

build/config/gcc/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/compiler/compiler.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/config/sysroot.gni")
 import("//build/toolchain/toolchain.gni")
 
 declare_args() {
@@ skipping 68 matching lines @@
     # Note: Android doesn't support rpath.
     if (shlib_subdir != ".") {
       rpath_link = "${shlib_subdir}/"
     } else {
       rpath_link = "."
     }
     if (current_toolchain != default_toolchain || gcc_target_rpath == "") {
       ldflags = [
         # Want to pass "\$". GN will re-escape as required for ninja.
         "-Wl,-rpath=\$ORIGIN/${rpath_link}",
-        "-Wl,-rpath-link=${rpath_link}",
+        "-Wl,-rpath-link=" + rebase_path(rpath_link, root_build_dir),

[brettw, 2017/05/30 03:57:56]

I don't understand this one, it looks like the input should already be relative
to the build dir. When does this one have an effect?

[wychen, 2017/05/30 06:34:05]

You are right. They don't have an effect.
Reverted.

Thanks for your eagle eye!

       ]
     } else {
       ldflags = [
         "-Wl,-rpath=${gcc_target_rpath}",
-        "-Wl,-rpath-link=${rpath_link}",
+        "-Wl,-rpath-link=" + rebase_path(rpath_link, root_build_dir),
       ]
     }
   }
 }
 
 # Settings for executables.
 config("executable_ldconfig") {
   # WARNING! //sandbox/linux:chrome_sandbox will not pick up this
   # config, because it is a setuid binary that needs special flags.
   # If you add things to this config, make sure you check to see
@@ skipping 22 matching lines @@
     _rpath_link = rebase_path(root_out_dir, root_build_dir)
     if (shlib_subdir != ".") {
       _rpath_link += "/$shlib_subdir"
     }
     if (is_android) {
       _rebased_sysroot = rebase_path(sysroot, root_build_dir)
       _rpath_link += ":$_rebased_sysroot/usr/lib"
     }
 
     ldflags += [
-      "-Wl,-rpath-link=$_rpath_link",
+      "-Wl,-rpath-link=" + rebase_path(_rpath_link, root_build_dir),

[brettw, 2017/05/30 03:57:56]

Ditto here.

 
       # TODO(GYP): Do we need a check on the binutils version here?
       #
       # Newer binutils don't set DT_RPATH unless you disable "new" dtags
       # and the new DT_RUNPATH doesn't work without --no-as-needed flag.
       "-Wl,--disable-new-dtags",
     ]
   }
 }
 
 config("no_exceptions") {
   cflags_cc = [ "-fno-exceptions" ]
   cflags_objcc = cflags_cc
 }