Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: third_party/WebKit/Source/core/page/CreateWindow.h

Issue 2905283003: Remove a bunch of dead code around WindowFeatures (Closed)
Patch Set: Use WebWindowFeatures everywhere Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/CreateWindow.h
diff --git a/third_party/WebKit/Source/core/page/CreateWindow.h b/third_party/WebKit/Source/core/page/CreateWindow.h
index ee4d3cc98d072f980e79535126c9b38f8350b910..557f25b8c0bf113a964f9a85a8898e9a09b949b1 100644
--- a/third_party/WebKit/Source/core/page/CreateWindow.h
+++ b/third_party/WebKit/Source/core/page/CreateWindow.h
@@ -39,11 +39,11 @@ namespace blink {
class ExceptionState;
class LocalFrame;
struct FrameLoadRequest;
-struct WindowFeatures;
+struct WebWindowFeatures;
DOMWindow* CreateWindow(const String& url_string,
const AtomicString& frame_name,
- const WindowFeatures&,
+ const String& window_features_string,
LocalDOMWindow& calling_window,
LocalFrame& first_frame,
LocalFrame& opener_frame,
@@ -53,6 +53,15 @@ void CreateWindowForRequest(const FrameLoadRequest&,
LocalFrame& opener_frame,
NavigationPolicy);
+// Exposed for testing
+CORE_EXPORT NavigationPolicy
+EffectiveNavigationPolicy(NavigationPolicy,
+ const WebInputEvent* current_event,
+ bool toolbar_visible);
+
+// Exposed for testing
+CORE_EXPORT WebWindowFeatures GetWindowFeaturesFromString(const String&);
+
} // namespace blink
#endif // CreateWindow_h

Powered by Google App Engine
This is Rietveld 408576698