Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: third_party/WebKit/Source/core/page/ChromeClient.cpp

Issue 2905283003: Remove a bunch of dead code around WindowFeatures (Closed)
Patch Set: Use WebWindowFeatures everywhere Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/ChromeClient.cpp
diff --git a/third_party/WebKit/Source/core/page/ChromeClient.cpp b/third_party/WebKit/Source/core/page/ChromeClient.cpp
index a4760020f967810acbe60f39034b2bd2d4d5d71b..4b08bd771e7422e05d17f60841f245dc14538d18 100644
--- a/third_party/WebKit/Source/core/page/ChromeClient.cpp
+++ b/third_party/WebKit/Source/core/page/ChromeClient.cpp
@@ -31,7 +31,6 @@
#include "core/page/FrameTree.h"
#include "core/page/Page.h"
#include "core/page/ScopedPageSuspender.h"
-#include "core/page/WindowFeatures.h"
#include "core/probe/CoreProbes.h"
#include "platform/geometry/IntRect.h"
#include "platform/network/NetworkHints.h"
@@ -86,15 +85,6 @@ bool ChromeClient::CanOpenModalIfDuringPageDismissal(
return true;
}
-void ChromeClient::SetWindowFeatures(const WindowFeatures& features) {
- SetToolbarsVisible(features.tool_bar_visible ||
- features.location_bar_visible);
- SetStatusbarVisible(features.status_bar_visible);
- SetScrollbarsVisible(features.scrollbars_visible);
- SetMenubarVisible(features.menu_bar_visible);
- SetResizable(features.resizable);
-}
-
template <typename Delegate>
static bool OpenJavaScriptDialog(LocalFrame* frame,
const String& message,

Powered by Google App Engine
This is Rietveld 408576698