Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Side by Side Diff: third_party/WebKit/Source/core/page/CreateWindow.h

Issue 2905283003: Remove a bunch of dead code around WindowFeatures (Closed)
Patch Set: Use WebWindowFeatures everywhere Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 21 matching lines...) Expand all
32 #include "core/loader/NavigationPolicy.h" 32 #include "core/loader/NavigationPolicy.h"
33 #include "platform/wtf/text/WTFString.h" 33 #include "platform/wtf/text/WTFString.h"
34 34
35 // To avoid conflicts with the CreateWindow macro from the Windows SDK... 35 // To avoid conflicts with the CreateWindow macro from the Windows SDK...
36 #undef CreateWindow 36 #undef CreateWindow
37 37
38 namespace blink { 38 namespace blink {
39 class ExceptionState; 39 class ExceptionState;
40 class LocalFrame; 40 class LocalFrame;
41 struct FrameLoadRequest; 41 struct FrameLoadRequest;
42 struct WindowFeatures; 42 struct WebWindowFeatures;
43 43
44 DOMWindow* CreateWindow(const String& url_string, 44 DOMWindow* CreateWindow(const String& url_string,
45 const AtomicString& frame_name, 45 const AtomicString& frame_name,
46 const WindowFeatures&, 46 const String& window_features_string,
47 LocalDOMWindow& calling_window, 47 LocalDOMWindow& calling_window,
48 LocalFrame& first_frame, 48 LocalFrame& first_frame,
49 LocalFrame& opener_frame, 49 LocalFrame& opener_frame,
50 ExceptionState&); 50 ExceptionState&);
51 51
52 void CreateWindowForRequest(const FrameLoadRequest&, 52 void CreateWindowForRequest(const FrameLoadRequest&,
53 LocalFrame& opener_frame, 53 LocalFrame& opener_frame,
54 NavigationPolicy); 54 NavigationPolicy);
55 55
56 // Exposed for testing
57 CORE_EXPORT NavigationPolicy
58 EffectiveNavigationPolicy(NavigationPolicy,
59 const WebInputEvent* current_event,
60 bool toolbar_visible);
61
62 // Exposed for testing
63 CORE_EXPORT WebWindowFeatures GetWindowFeaturesFromString(const String&);
64
56 } // namespace blink 65 } // namespace blink
57 66
58 #endif // CreateWindow_h 67 #endif // CreateWindow_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698