Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: third_party/WebKit/Source/core/page/Page.h

Issue 2905283003: Remove a bunch of dead code around WindowFeatures (Closed)
Patch Set: Use WebWindowFeatures everywhere Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/Page.h
diff --git a/third_party/WebKit/Source/core/page/Page.h b/third_party/WebKit/Source/core/page/Page.h
index f1ef96350e2407cde1e8a7eafa692e92e82e6625..6258d19a4e9dd872fd5beada32ba55550bbdaf73 100644
--- a/third_party/WebKit/Source/core/page/Page.h
+++ b/third_party/WebKit/Source/core/page/Page.h
@@ -43,6 +43,7 @@
#include "platform/wtf/HashSet.h"
#include "platform/wtf/Noncopyable.h"
#include "platform/wtf/text/WTFString.h"
+#include "public/web/WebWindowFeatures.h"
dcheng 2017/06/02 18:46:22 I'm not actually sure what the rules are on #inclu
Nate Chapin 2017/06/02 20:20:23 kinuko suggested it in https://codereview.chromium
namespace blink {
@@ -185,6 +186,13 @@ class CORE_EXPORT Page final : public GarbageCollectedFinalized<Page>,
Deprecation& GetDeprecation() { return deprecation_; }
HostsUsingFeatures& GetHostsUsingFeatures() { return hosts_using_features_; }
+ void SetWindowFeatures(const WebWindowFeatures& features) {
+ window_features_ = features;
+ }
+ const WebWindowFeatures& GetWindowFeatures() const {
+ return window_features_;
+ }
+
PageScaleConstraintsSet& GetPageScaleConstraintsSet();
const PageScaleConstraintsSet& GetPageScaleConstraintsSet() const;
@@ -333,6 +341,7 @@ class CORE_EXPORT Page final : public GarbageCollectedFinalized<Page>,
UseCounter use_counter_;
Deprecation deprecation_;
HostsUsingFeatures hosts_using_features_;
+ WebWindowFeatures window_features_;
bool opened_by_dom_;
// Set to true when window.close() has been called and the Page will be

Powered by Google App Engine
This is Rietveld 408576698