Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: third_party/WebKit/Source/core/page/ChromeClient.h

Issue 2905283003: Remove a bunch of dead code around WindowFeatures (Closed)
Patch Set: Use WebWindowFeatures everywhere Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/ChromeClient.h
diff --git a/third_party/WebKit/Source/core/page/ChromeClient.h b/third_party/WebKit/Source/core/page/ChromeClient.h
index de24ec369655edf13c0c0d53ecffe4c2a9b1e6b1..0c2d57669b0dd5e36f4a793f05d45e9488b3bc2c 100644
--- a/third_party/WebKit/Source/core/page/ChromeClient.h
+++ b/third_party/WebKit/Source/core/page/ChromeClient.h
@@ -91,7 +91,7 @@ struct ViewportDescription;
struct WebCursorInfo;
struct WebPoint;
struct WebScreenInfo;
-struct WindowFeatures;
+struct WebWindowFeatures;
class CORE_EXPORT ChromeClient : public PlatformChromeClient {
public:
@@ -131,11 +131,9 @@ class CORE_EXPORT ChromeClient : public PlatformChromeClient {
// request could be fulfilled. The ChromeClient should not load the request.
virtual Page* CreateWindow(LocalFrame*,
const FrameLoadRequest&,
- const WindowFeatures&,
+ const WebWindowFeatures&,
NavigationPolicy) = 0;
- virtual void Show(NavigationPolicy = kNavigationPolicyIgnore) = 0;
-
- void SetWindowFeatures(const WindowFeatures&);
+ virtual void Show(NavigationPolicy) = 0;
// All the parameters should be in viewport space. That is, if an event
// scrolls by 10 px, but due to a 2X page scale we apply a 5px scroll to the
@@ -146,20 +144,6 @@ class CORE_EXPORT ChromeClient : public PlatformChromeClient {
const FloatPoint& position_in_viewport,
const FloatSize& velocity_in_viewport) = 0;
- virtual void SetToolbarsVisible(bool) = 0;
- virtual bool ToolbarsVisible() = 0;
-
- virtual void SetStatusbarVisible(bool) = 0;
- virtual bool StatusbarVisible() = 0;
-
- virtual void SetScrollbarsVisible(bool) = 0;
- virtual bool ScrollbarsVisible() = 0;
-
- virtual void SetMenubarVisible(bool) = 0;
- virtual bool MenubarVisible() = 0;
-
- virtual void SetResizable(bool) = 0;
-
virtual bool ShouldReportDetailedMessageForSource(LocalFrame&,
const String& source) = 0;
virtual void AddMessageToConsole(LocalFrame*,
@@ -280,6 +264,7 @@ class CORE_EXPORT ChromeClient : public PlatformChromeClient {
WebEventListenerClass) const = 0;
virtual void UpdateEventRectsForSubframeIfNecessary(LocalFrame*) = 0;
virtual void SetHasScrollEventHandlers(LocalFrame*, bool) = 0;
+ virtual const WebInputEvent* GetCurrentInputEvent() const { return nullptr; }
virtual void SetTouchAction(LocalFrame*, TouchAction) = 0;

Powered by Google App Engine
This is Rietveld 408576698