Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 2905283003: Remove a bunch of dead code around WindowFeatures (Closed)
Patch Set: Use WebWindowFeatures everywhere Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
index 2e8f1551f3b37d860ea623ce19ad56d6f56929de..5b5effb8de2a30060017fbb229e1520e18201256 100644
--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
@@ -75,7 +75,6 @@
#include "core/page/ChromeClient.h"
#include "core/page/CreateWindow.h"
#include "core/page/Page.h"
-#include "core/page/WindowFeatures.h"
#include "core/page/scrolling/ScrollingCoordinator.h"
#include "core/probe/CoreProbes.h"
#include "core/timing/DOMWindowPerformance.h"
@@ -1638,11 +1637,10 @@ DOMWindow* LocalDOMWindow::open(const String& url_string,
return target_frame->DomWindow();
}
- WindowFeatures features(window_features_string);
DOMWindow* new_window =
- CreateWindow(url_string, frame_name, features, *calling_window,
- *first_frame, *GetFrame(), exception_state);
- return features.noopener ? nullptr : new_window;
+ CreateWindow(url_string, frame_name, window_features_string,
+ *calling_window, *first_frame, *GetFrame(), exception_state);
+ return new_window;
}
DEFINE_TRACE(LocalDOMWindow) {

Powered by Google App Engine
This is Rietveld 408576698