Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: third_party/WebKit/Source/core/frame/BarProp.cpp

Issue 2905283003: Remove a bunch of dead code around WindowFeatures (Closed)
Patch Set: Use WebWindowFeatures everywhere Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/BarProp.cpp
diff --git a/third_party/WebKit/Source/core/frame/BarProp.cpp b/third_party/WebKit/Source/core/frame/BarProp.cpp
index 49dd57632c8fed7b646195ced0c6a745e9968225..70e39773e3a00d52e8cc929674c885caf6a76a25 100644
--- a/third_party/WebKit/Source/core/frame/BarProp.cpp
+++ b/third_party/WebKit/Source/core/frame/BarProp.cpp
@@ -29,8 +29,8 @@
#include "core/frame/BarProp.h"
#include "core/frame/LocalFrame.h"
-#include "core/page/ChromeClient.h"
#include "core/page/Page.h"
+#include "public/web/WebWindowFeatures.h"
namespace blink {
@@ -46,17 +46,19 @@ bool BarProp::visible() const {
return false;
DCHECK(GetFrame()->GetPage());
+ const WebWindowFeatures& features =
+ GetFrame()->GetPage()->GetWindowFeatures();
switch (type_) {
case kLocationbar:
case kPersonalbar:
case kToolbar:
- return GetFrame()->GetPage()->GetChromeClient().ToolbarsVisible();
+ return features.tool_bar_visible;
case kMenubar:
- return GetFrame()->GetPage()->GetChromeClient().MenubarVisible();
+ return features.menu_bar_visible;
case kScrollbars:
- return GetFrame()->GetPage()->GetChromeClient().ScrollbarsVisible();
+ return features.scrollbars_visible;
case kStatusbar:
- return GetFrame()->GetPage()->GetChromeClient().StatusbarVisible();
+ return features.status_bar_visible;
}
NOTREACHED();

Powered by Google App Engine
This is Rietveld 408576698