Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: third_party/WebKit/Source/core/loader/EmptyClients.h

Issue 2905283003: Remove a bunch of dead code around WindowFeatures (Closed)
Patch Set: Use WebWindowFeatures everywhere Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/EmptyClients.h
diff --git a/third_party/WebKit/Source/core/loader/EmptyClients.h b/third_party/WebKit/Source/core/loader/EmptyClients.h
index f6469c8ae6e56782aeb19aa5b7a5996ff0593dc5..a23732ab45522dc8ad380768365058c88fae4456 100644
--- a/third_party/WebKit/Source/core/loader/EmptyClients.h
+++ b/third_party/WebKit/Source/core/loader/EmptyClients.h
@@ -95,7 +95,7 @@ class CORE_EXPORT EmptyChromeClient : public ChromeClient {
void FocusedNodeChanged(Node*, Node*) override {}
Page* CreateWindow(LocalFrame*,
const FrameLoadRequest&,
- const WindowFeatures&,
+ const WebWindowFeatures&,
NavigationPolicy) override {
return nullptr;
}
@@ -117,20 +117,6 @@ class CORE_EXPORT EmptyChromeClient : public ChromeClient {
const WebPoint& drag_image_offset) {}
bool AcceptsLoadDrops() const override { return true; }
- void SetToolbarsVisible(bool) override {}
- bool ToolbarsVisible() override { return false; }
-
- void SetStatusbarVisible(bool) override {}
- bool StatusbarVisible() override { return false; }
-
- void SetScrollbarsVisible(bool) override {}
- bool ScrollbarsVisible() override { return false; }
-
- void SetMenubarVisible(bool) override {}
- bool MenubarVisible() override { return false; }
-
- void SetResizable(bool) override {}
-
bool ShouldReportDetailedMessageForSource(LocalFrame&,
const String&) override {
return false;

Powered by Google App Engine
This is Rietveld 408576698