Make CompositorView be visible and have a background color on creation.

Make CompositorView be visible and have a background color on creation.

This moves the visibility and background color setting for the
placeholder CompositorView in the constructor (before native is loaded).
This gives the View system the opportunity to draw a white frame earlier
-- in the current codepath we set the SurfaceView and CompositorView
visibility at the same time on native load, it appears that they race
and black is shown when the SurfaceView frame is suppressed by
surfaceRedrawAsyncNeeded.

This patch doesn't change visibility timing of the SurfaceView itself,
because it has the important side effect of suppressing surfaceCreated
and surfaceChanged when the native side is not yet ready to handle them.

BUG=726564
Review-Url: https://codereview.chromium.org/2905113003
Cr-Commit-Position: refs/heads/master@{#475056}
Committed: https://chromium.googlesource.com/chromium/src/+/f7b1b07daa4fb6337f9806a00e3a299aeb613641

[aelias_OOO_until_Jul13, 2017-05-26 03:54:35]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 03:55:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-05-26 04:11:32]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 04:12:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-05-26 04:12:51]

aelias@chromium.org changed reviewers:
+ changwan@chromium.org

[aelias_OOO_until_Jul13, 2017-05-26 04:13:33]

Hi changwan@, PTAL.  (boliu@ is OOO on Friday so he can't do the initial round
of review.)

[commit-bot: I haz the power, 2017-05-26 05:47:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 05:47:47]

Dry run: This issue passed the CQ dry run.

[boliu, 2017-05-26 15:44:23]

boliu@chromium.org changed reviewers:
+ boliu@chromium.org

[boliu, 2017-05-26 15:44:24]

actually change of plans, still around today :p

lgtm

[Changwan Ryu, 2017-05-26 16:09:58]

lgtm

[aelias_OOO_until_Jul13, 2017-05-26 17:49:55]

The CQ bit was checked by aelias@chromium.org

[commit-bot: I haz the power, 2017-05-26 17:50:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 17:55:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495820995331720,
"parent_rev": "e20db1477605751eae3d4490852049e21b781e98", "commit_rev":
"f7b1b07daa4fb6337f9806a00e3a299aeb613641"}

[commit-bot: I haz the power, 2017-05-26 17:55:16]

Description was changed from

==========
Make CompositorView be visible and have a background color on creation.

This moves the visibility and background color setting for the
placeholder CompositorView in the constructor (before native is loaded).
This gives the View system the opportunity to draw a white frame earlier
-- in the current codepath we set the SurfaceView and CompositorView
visibility at the same time on native load, it appears that they race
and black is shown when the SurfaceView frame is suppressed by
surfaceRedrawAsyncNeeded.

This patch doesn't change visibility timing of the SurfaceView itself,
because it has the important side effect of suppressing surfaceCreated
and surfaceChanged when the native side is not yet ready to handle them.

BUG=726564
==========

to

==========
Make CompositorView be visible and have a background color on creation.

This moves the visibility and background color setting for the
placeholder CompositorView in the constructor (before native is loaded).
This gives the View system the opportunity to draw a white frame earlier
-- in the current codepath we set the SurfaceView and CompositorView
visibility at the same time on native load, it appears that they race
and black is shown when the SurfaceView frame is suppressed by
surfaceRedrawAsyncNeeded.

This patch doesn't change visibility timing of the SurfaceView itself,
because it has the important side effect of suppressing surfaceCreated
and surfaceChanged when the native side is not yet ready to handle them.

BUG=726564

Review-Url: https://codereview.chromium.org/2905113003
Cr-Commit-Position: refs/heads/master@{#475056}
Committed:
https://chromium.googlesource.com/chromium/src/+/f7b1b07daa4fb6337f9806a00e3a...
==========

[commit-bot: I haz the power, 2017-05-26 17:55:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f7b1b07daa4fb6337f9806a00e3a...