Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3100)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/compositor/CompositorVisibilityTest.java

Issue 2905113003: Make CompositorView be visible and have a background color on creation. (Closed)
Patch Set: Add unit test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/compositor/CompositorVisibilityTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/compositor/CompositorVisibilityTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/compositor/CompositorVisibilityTest.java
index 9c0407715867d87b2d30eaaa80353544c74f1a74..1c20f20c4dd5150daaf1f67f1285183e1ba48028 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/compositor/CompositorVisibilityTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/compositor/CompositorVisibilityTest.java
@@ -124,4 +124,20 @@ public class CompositorVisibilityTest {
}
});
}
+
+ // CompositorView placeholder initial visibility should be true to show white placeholder when
+ // needed, but SurfaceView initial visibility should be false to delay
+ // surfaceChanged/surfaceCreated calls.
+ @Test
+ @SmallTest
+ public void testInitialVisibility() throws Throwable {
+ mActivityTestRule.runOnUiThread(new Runnable() {
+ @Override
+ public void run() {
+ mCompositorView = new CompositorView(mActivityTestRule.getActivity(), mRenderHost);
+ Assert.assertEquals(View.VISIBLE, mCompositorView.getVisibility());
+ Assert.assertEquals(View.INVISIBLE, mCompositorView.getChildAt(0).getVisibility());
+ }
+ });
+ }
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698