Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java

Issue 2905113003: Make CompositorView be visible and have a background color on creation. (Closed)
Patch Set: Add unit test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java
index e63d30a8499232ec5fb3d1e302183e79a26addc6..64e4e2743f028a2d945f09fe23b5d5f3547e36d6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java
@@ -94,7 +94,11 @@ public class CompositorView
mCompositorSurfaceManager = new CompositorSurfaceManager(this, this);
- setVisibility(View.INVISIBLE);
+ // Cover the black surface before it has valid content. Set this placeholder view to
+ // visible, but don't yet make SurfaceView visible, in order to delay
+ // surfaceCreate/surfaceChanged calls until the native library is loaded.
+ setBackgroundColor(Color.WHITE);
+ super.setVisibility(View.VISIBLE);
// Request the opaque surface. We might need the translucent one, but
// we don't know yet. We'll switch back later if we discover that
@@ -195,8 +199,6 @@ public class CompositorView
// re-request the surface now.
mCompositorSurfaceManager.requestSurface(getSurfacePixelFormat());
- // Cover the black surface before it has valid content.
- setBackgroundColor(Color.WHITE);
setVisibility(View.VISIBLE);
mFramePresentationDelay = 0;

Powered by Google App Engine
This is Rietveld 408576698