Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2904823003: DevTools: remove unused preventFollow (Closed)

Created:
3 years, 7 months ago by luoe
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove unused preventFollow The preventFollow was first introduced to prevent links in Elements panel's tree outline and SSP from opening on click https://codereview.chromium.org/661103002 A later migration to preventClick removed all instances of preventFollow except the one in this CL: https://codereview.chromium.org/2519213002 BUG=none Review-Url: https://codereview.chromium.org/2904823003 Cr-Commit-Position: refs/heads/master@{#474884} Committed: https://chromium.googlesource.com/chromium/src/+/664bafb55e38f92f6ba470a7311ce4bca23f5888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/components/Linkifier.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
luoe
Please take a look
3 years, 7 months ago (2017-05-24 22:04:41 UTC) #3
dgozman
lgtm
3 years, 7 months ago (2017-05-25 22:14:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904823003/1
3 years, 7 months ago (2017-05-25 22:16:05 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 02:39:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/664bafb55e38f92f6ba470a7311c...

Powered by Google App Engine
This is Rietveld 408576698