Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 661103002: DevTools: make web component anchor handling go the generic route. (Closed)

Created:
6 years, 2 months ago by pfeldman
Modified:
6 years, 2 months ago
Reviewers:
apavlov, aandrey
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: make web component anchor handling go the generic route. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183948

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -11 lines) Patch
M Source/devtools/front_end/elements/ElementsPanel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsTreeOutline.js View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/devtools/front_end/elementsTreeOutline.css View 1 chunk +5 lines, -1 line 0 comments Download
M Source/devtools/front_end/main/Main.js View 2 chunks +6 lines, -2 lines 1 comment Download
M Source/devtools/front_end/resources/ResourcesPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/DOMExtension.js View 1 chunk +11 lines, -2 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
pfeldman
6 years, 2 months ago (2014-10-17 15:38:37 UTC) #2
apavlov
lgtm https://codereview.chromium.org/661103002/diff/1/Source/devtools/front_end/ui/DOMExtension.js File Source/devtools/front_end/ui/DOMExtension.js (right): https://codereview.chromium.org/661103002/diff/1/Source/devtools/front_end/ui/DOMExtension.js#newcode796 Source/devtools/front_end/ui/DOMExtension.js:796: // 1. climb to the component root. climb ...
6 years, 2 months ago (2014-10-17 15:40:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661103002/1
6 years, 2 months ago (2014-10-17 15:53:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/69678)
6 years, 2 months ago (2014-10-17 16:27:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661103002/1
6 years, 2 months ago (2014-10-19 14:05:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 183948
6 years, 2 months ago (2014-10-19 14:45:47 UTC) #10
aandrey
6 years, 2 months ago (2014-10-20 13:37:14 UTC) #12
Message was sent while issue was closed. 
please fix

https://codereview.chromium.org/661103002/diff/1/Source/devtools/front_end/ma...
File Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/661103002/diff/1/Source/devtools/front_end/ma...
Source/devtools/front_end/main/Main.js:382: var anchor =
target.enclosingNodeOrSelfWithNodeName("a");
"Uncaught TypeError: Cannot read property 'enclosingNodeOrSelfWithNodeName' of
null", source: chrome-devtools://devtools/bundled/main/Main.js (387)

Powered by Google App Engine
This is Rietveld 408576698