Change ContentData::operator== to iterate through whole list.

Change ContentData::operator== to iterate through whole list.

ContentData is a class that has a linked list structure. To compare two
ContentDatas, ComputedStyle iterates through the two lists and checks
that each element is equal using operator==, which calls through to
ContentData::Equals.

Instead of leaving the iteration logic in ComputedStyle, this patch
moves it to operator==, so that operator== iterates through the two
linked lists and compares each element using ContentData::Equals. This
allows ComputedStyle to just use operator== on ContentData.

This transformation causes no behavioural changes as ContentData's
operator== was only used by ComputedStyle.

BUG=628043
Review-Url: https://codereview.chromium.org/2904723002
Cr-Commit-Position: refs/heads/master@{#474408}
Committed: https://chromium.googlesource.com/chromium/src/+/e452a38ed13a4b9c472196221494d228a8be7f30

[shend, 2017-05-23 23:02:35]

shend@chromium.org changed reviewers:
+ alancutter@chromium.org

[shend, 2017-05-23 23:02:35]

Hi Alan, PTAL

[alancutter (OOO until 2018), 2017-05-24 01:43:37]

lgtm

[shend, 2017-05-24 01:43:56]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 01:45:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 04:41:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 04:41:09]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-24 05:50:15]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 05:50:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 07:42:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 07:42:43]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-24 20:37:06]

The CQ bit was checked by shend@chromium.org

[shend, 2017-05-24 20:37:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2904723002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-24 20:37:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 20:43:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495658226756400,
"parent_rev": "be87e8045e54529aa63ee58c8ebc68092c07ca48", "commit_rev":
"e452a38ed13a4b9c472196221494d228a8be7f30"}

[commit-bot: I haz the power, 2017-05-24 20:44:05]

Description was changed from

==========
Change ContentData::operator== to iterate through whole list.

ContentData is a class that has a linked list structure. To compare two
ContentDatas, ComputedStyle iterates through the two lists and checks
that each element is equal using operator==, which calls through to
ContentData::Equals.

Instead of leaving the iteration logic in ComputedStyle, this patch
moves it to operator==, so that operator== iterates through the two
linked lists and compares each element using ContentData::Equals. This
allows ComputedStyle to just use operator== on ContentData.

This transformation causes no behavioural changes as ContentData's
operator== was only used by ComputedStyle.

BUG=628043
==========

to

==========
Change ContentData::operator== to iterate through whole list.

ContentData is a class that has a linked list structure. To compare two
ContentDatas, ComputedStyle iterates through the two lists and checks
that each element is equal using operator==, which calls through to
ContentData::Equals.

Instead of leaving the iteration logic in ComputedStyle, this patch
moves it to operator==, so that operator== iterates through the two
linked lists and compares each element using ContentData::Equals. This
allows ComputedStyle to just use operator== on ContentData.

This transformation causes no behavioural changes as ContentData's
operator== was only used by ComputedStyle.

BUG=628043

Review-Url: https://codereview.chromium.org/2904723002
Cr-Commit-Position: refs/heads/master@{#474408}
Committed:
https://chromium.googlesource.com/chromium/src/+/e452a38ed13a4b9c472196221494...
==========

[commit-bot: I haz the power, 2017-05-24 20:44:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e452a38ed13a4b9c472196221494...