Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2904443002: Add operator== to CSSAnimationData. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add operator== to CSSAnimationData. This patch adds an operator== to CSSAnimationData that is used by ComputedStyle to check equality for style resolve. Note this is different to a full, memberwise equality. BUG=628043 Review-Url: https://codereview.chromium.org/2904443002 Cr-Commit-Position: refs/heads/master@{#474241} Committed: https://chromium.googlesource.com/chromium/src/+/77a0c5f701d4bf72cb998c69496a65725fbb719e

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M third_party/WebKit/Source/core/animation/css/CSSAnimationData.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp View 1 1 chunk +1 line, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (16 generated)
shend
Hi Alan, PTAL :)
3 years, 7 months ago (2017-05-23 06:50:26 UTC) #4
alancutter (OOO until 2018)
lgtm https://codereview.chromium.org/2904443002/diff/1/third_party/WebKit/Source/core/animation/css/CSSAnimationData.h File third_party/WebKit/Source/core/animation/css/CSSAnimationData.h (right): https://codereview.chromium.org/2904443002/diff/1/third_party/WebKit/Source/core/animation/css/CSSAnimationData.h#newcode28 third_party/WebKit/Source/core/animation/css/CSSAnimationData.h:28: return AnimationsMatchForStyleRecalc(other); I like how you retained the ...
3 years, 7 months ago (2017-05-23 08:06:29 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2893243002 Patch 20001). Please resolve the dependency and ...
3 years, 7 months ago (2017-05-23 22:25:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904443002/20001
3 years, 7 months ago (2017-05-24 10:19:51 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 10:24:26 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/77a0c5f701d4bf72cb998c69496a...

Powered by Google App Engine
This is Rietveld 408576698