Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Side by Side Diff: third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp

Issue 2904723002: Change ContentData::operator== to iterate through whole list. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/style/ContentData.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org) 2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 o.requires_accelerated_compositing_for_external_reasons_ && 285 o.requires_accelerated_compositing_for_external_reasons_ &&
286 has_inline_transform_ == o.has_inline_transform_ && 286 has_inline_transform_ == o.has_inline_transform_ &&
287 resize_ == o.resize_ && 287 resize_ == o.resize_ &&
288 has_compositor_proxy_ == o.has_compositor_proxy_ && 288 has_compositor_proxy_ == o.has_compositor_proxy_ &&
289 has_author_background_ == o.has_author_background_ && 289 has_author_background_ == o.has_author_background_ &&
290 has_author_border_ == o.has_author_border_; 290 has_author_border_ == o.has_author_border_;
291 } 291 }
292 292
293 bool StyleRareNonInheritedData::ContentDataEquivalent( 293 bool StyleRareNonInheritedData::ContentDataEquivalent(
294 const StyleRareNonInheritedData& o) const { 294 const StyleRareNonInheritedData& o) const {
295 ContentData* a = content_.Get(); 295 return DataEquivalent(content_, o.content_);
296 ContentData* b = o.content_.Get();
297
298 while (a && b && *a == *b) {
299 a = a->Next();
300 b = b->Next();
301 }
302
303 return !a && !b;
304 } 296 }
305 297
306 bool StyleRareNonInheritedData::CounterDataEquivalent( 298 bool StyleRareNonInheritedData::CounterDataEquivalent(
307 const StyleRareNonInheritedData& o) const { 299 const StyleRareNonInheritedData& o) const {
308 return DataEquivalent(counter_directives_, o.counter_directives_); 300 return DataEquivalent(counter_directives_, o.counter_directives_);
309 } 301 }
310 302
311 bool StyleRareNonInheritedData::ShadowDataEquivalent( 303 bool StyleRareNonInheritedData::ShadowDataEquivalent(
312 const StyleRareNonInheritedData& o) const { 304 const StyleRareNonInheritedData& o) const {
313 return DataEquivalent(box_shadow_, o.box_shadow_); 305 return DataEquivalent(box_shadow_, o.box_shadow_);
(...skipping 30 matching lines...) Expand all
344 const StyleRareNonInheritedData& o) const { 336 const StyleRareNonInheritedData& o) const {
345 return DataEquivalent(shape_outside_, o.shape_outside_); 337 return DataEquivalent(shape_outside_, o.shape_outside_);
346 } 338 }
347 339
348 bool StyleRareNonInheritedData::ClipPathDataEquivalent( 340 bool StyleRareNonInheritedData::ClipPathDataEquivalent(
349 const StyleRareNonInheritedData& o) const { 341 const StyleRareNonInheritedData& o) const {
350 return DataEquivalent(clip_path_, o.clip_path_); 342 return DataEquivalent(clip_path_, o.clip_path_);
351 } 343 }
352 344
353 } // namespace blink 345 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/style/ContentData.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698