Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2904593002: Refactor Environment Config Out of TaskSchedulerImpl (Closed)

Created:
3 years, 7 months ago by robliao
Modified:
3 years, 7 months ago
Reviewers:
gab, fdoray
CC:
chromium-reviews, gab+watch_chromium.org, danakj+watch_chromium.org, fdoray+watch_chromium.org, robliao+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor Environment Config Out of TaskSchedulerImpl The upcoming shared SingleThreadTaskRunner work will need access to the same environment config as TaskSchedulerImpl. BUG=720058 Review-Url: https://codereview.chromium.org/2904593002 Cr-Commit-Position: refs/heads/master@{#474066} Committed: https://chromium.googlesource.com/chromium/src/+/767ec996d88c8f8719a4648b891b5e10501a7a99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -36 lines) Patch
M base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A base/task_scheduler/environment_config.h View 1 chunk +45 lines, -0 lines 0 comments Download
A base/task_scheduler/environment_config.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl.cc View 2 chunks +1 line, -36 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
robliao
3 years, 7 months ago (2017-05-23 17:38:15 UTC) #2
gab
lgtm
3 years, 7 months ago (2017-05-23 17:44:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904593002/1
3 years, 7 months ago (2017-05-23 20:07:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/767ec996d88c8f8719a4648b891b5e10501a7a99
3 years, 7 months ago (2017-05-23 21:36:40 UTC) #12
fdoray
3 years, 7 months ago (2017-05-24 12:20:16 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698