Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: base/task_scheduler/task_scheduler_impl.cc

Issue 2904593002: Refactor Environment Config Out of TaskSchedulerImpl (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/environment_config.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/task_scheduler_impl.cc
diff --git a/base/task_scheduler/task_scheduler_impl.cc b/base/task_scheduler/task_scheduler_impl.cc
index b1b2d36c11696d280c43387a4f209c767f2bb706..66880a85d4110a0018afd3efdc52c24efb665833 100644
--- a/base/task_scheduler/task_scheduler_impl.cc
+++ b/base/task_scheduler/task_scheduler_impl.cc
@@ -8,6 +8,7 @@
#include "base/memory/ptr_util.h"
#include "base/task_scheduler/delayed_task_manager.h"
+#include "base/task_scheduler/environment_config.h"
#include "base/task_scheduler/scheduler_worker_pool_params.h"
#include "base/task_scheduler/sequence.h"
#include "base/task_scheduler/sequence_sort_key.h"
@@ -17,42 +18,6 @@
namespace base {
namespace internal {
-namespace {
-
-enum EnvironmentType {
- BACKGROUND = 0,
- BACKGROUND_BLOCKING,
- FOREGROUND,
- FOREGROUND_BLOCKING,
- ENVIRONMENT_COUNT // Always last.
-};
-
-// Order must match the EnvironmentType enum.
-constexpr struct {
- // The threads and histograms of this environment will be labeled with
- // the task scheduler name concatenated to this.
- const char* name_suffix;
-
- // Preferred priority for threads in this environment; the actual thread
- // priority depends on shutdown state and platform capabilities.
- ThreadPriority priority_hint;
-} kEnvironmentParams[] = {
- {"Background", base::ThreadPriority::BACKGROUND},
- {"BackgroundBlocking", base::ThreadPriority::BACKGROUND},
- {"Foreground", base::ThreadPriority::NORMAL},
- {"ForegroundBlocking", base::ThreadPriority::NORMAL},
-};
-
-size_t GetEnvironmentIndexForTraits(const TaskTraits& traits) {
- const bool is_background =
- traits.priority() == base::TaskPriority::BACKGROUND;
- if (traits.may_block() || traits.with_base_sync_primitives())
- return is_background ? BACKGROUND_BLOCKING : FOREGROUND_BLOCKING;
- return is_background ? BACKGROUND : FOREGROUND;
-}
-
-} // namespace
-
TaskSchedulerImpl::TaskSchedulerImpl(StringPiece name)
: name_(name),
service_thread_("TaskSchedulerServiceThread"),
« no previous file with comments | « base/task_scheduler/environment_config.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698