Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Issue 2906573002: Use Dedicated Threads for BrowserThreads Backed by SingleThreadTaskRunners (Closed)

Created:
3 years, 6 months ago by robliao
Modified:
3 years, 6 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Dedicated Threads for BrowserThreads Backed by SingleThreadTaskRunners BUG=720058 Review-Url: https://codereview.chromium.org/2906573002 Cr-Commit-Position: refs/heads/master@{#474652} Committed: https://chromium.googlesource.com/chromium/src/+/b29b8d8833bf2f8fa7c1a33a90cf7d96a44d79ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M content/browser/browser_main_loop.cc View 2 chunks +7 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (11 generated)
robliao
3 years, 6 months ago (2017-05-25 00:54:31 UTC) #4
gab
Haha, I just did the same survey of existing CreateSingleThreadTaskRunner sites and had written the ...
3 years, 6 months ago (2017-05-25 01:22:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906573002/1
3 years, 6 months ago (2017-05-25 07:36:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/447227)
3 years, 6 months ago (2017-05-25 07:44:12 UTC) #11
gab
+avi for r-s, please CQ
3 years, 6 months ago (2017-05-25 12:40:47 UTC) #13
Avi (use Gerrit)
lgtm
3 years, 6 months ago (2017-05-25 14:55:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906573002/1
3 years, 6 months ago (2017-05-25 14:56:05 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-05-25 15:00:03 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b29b8d8833bf2f8fa7c1a33a90cf...

Powered by Google App Engine
This is Rietveld 408576698